Option to overwrite a Receive State in the Scan Delegator #62609

pmullt · 2023-09-13T16:05:33Z

Kconfig option CONFIG_SD_RECEIVE_STATE_OVERWRITE_OLDEST allows the Scan Delegator to overwrite the oldest updated receive state which is not being synced, if receive states are full.

There is also a recv_states_full() callback function added which can notify an application if all receive states are full and being synced.

github-actions

Hello @pmullt, and thank you very much for your first pull request to the Zephyr project!

A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊

include/zephyr/bluetooth/audio/bap.h

samples/bluetooth/broadcast_audio_sink/Kconfig

subsys/bluetooth/audio/bap_scan_delegator.c

include/zephyr/bluetooth/audio/bap.h

subsys/bluetooth/audio/bap_scan_delegator.c

Thalley

Nice work so far, but with some comments on the approach with the big as well as some formatting

subsys/bluetooth/audio/Kconfig.bap

include/zephyr/bluetooth/audio/bap.h

subsys/bluetooth/audio/bap_scan_delegator.c

carlescufi · 2023-09-28T11:17:10Z

@pmullt feature freeze is tomorrow. If you'd like to get this into Zephyr 3.5 please address all review comments before EOB tomorrow.

Thalley

A few more comments, but I think it's nearly there

include/zephyr/bluetooth/audio/bap.h

subsys/bluetooth/audio/bap_broadcast_sink.c

subsys/bluetooth/audio/bap_scan_delegator.c

Thalley

Looks pretty good now - Mostly some formatting comments

include/zephyr/bluetooth/audio/bap.h

subsys/bluetooth/audio/bap_broadcast_sink.c

subsys/bluetooth/audio/bap_scan_delegator.c

Thalley · 2023-10-17T09:33:34Z

subsys/bluetooth/audio/bap_scan_delegator.c

+		if (scan_delegator_cbs != NULL &&
+			scan_delegator_cbs->recv_state_add_failed != NULL) {


Suggested change

if (scan_delegator_cbs != NULL &&

scan_delegator_cbs->recv_state_add_failed != NULL) {

if (scan_delegator_cbs != NULL &&

scan_delegator_cbs->recv_state_add_failed != NULL) {

subsys/bluetooth/audio/bap_scan_delegator.c

Thalley

Mostly formatting.

Have you consider using something like clang-format to help your formatting?

subsys/bluetooth/audio/bap_broadcast_sink.c

Thalley · 2023-10-18T10:51:14Z

subsys/bluetooth/audio/bap_scan_delegator.c

+		if (state->pa_sync_state == BT_BAP_PA_STATE_SYNCED ||
+			state->pa_sync_state ==	BT_BAP_PA_STATE_INFO_REQ) {


Suggested change

if (state->pa_sync_state == BT_BAP_PA_STATE_SYNCED ||

state->pa_sync_state == BT_BAP_PA_STATE_INFO_REQ) {

if (state->pa_sync_state == BT_BAP_PA_STATE_SYNCED ||

state->pa_sync_state == BT_BAP_PA_STATE_INFO_REQ) {

subsys/bluetooth/audio/bap_scan_delegator.c

Thalley · 2023-10-18T10:51:47Z

subsys/bluetooth/audio/bap_scan_delegator.c

+		if ((oldest_inactive_state == NULL) ||
+			(current_state->aging_counter < oldest_inactive_state->aging_counter)) {


Suggested change

if ((oldest_inactive_state == NULL) ||

(current_state->aging_counter < oldest_inactive_state->aging_counter)) {

if ((oldest_inactive_state == NULL) ||

(current_state->aging_counter < oldest_inactive_state->aging_counter)) {

subsys/bluetooth/audio/bap_scan_delegator.c

Thalley · 2023-10-18T10:53:12Z

subsys/bluetooth/audio/bap_scan_delegator.c

+		(void)memcpy(&state_info.subgroups, &param->subgroups,
+					 sizeof(state_info.subgroups));


Suggested change

(void)memcpy(&state_info.subgroups, &param->subgroups,

sizeof(state_info.subgroups));

(void)memcpy(&state_info.subgroups, &param->subgroups,

sizeof(state_info.subgroups));

Thalley · 2023-10-18T10:53:21Z

subsys/bluetooth/audio/bap_scan_delegator.c

+	LOG_DBG("New source ID 0x%02x (%d) added to Scan Delegator at Index %u: ",
+			state->src_id, state->src_id, internal_state->index);


Suggested change

LOG_DBG("New source ID 0x%02x (%d) added to Scan Delegator at Index %u: ",

state->src_id, state->src_id, internal_state->index);

LOG_DBG("New source ID 0x%02x (%d) added to Scan Delegator at Index %u: ",

state->src_id, state->src_id, internal_state->index);

subsys/bluetooth/audio/bap_scan_delegator.c

include/zephyr/bluetooth/audio/bap.h

subsys/bluetooth/audio/bap_broadcast_sink.c

subsys/bluetooth/audio/bap_scan_delegator.c

Thalley

Still a few formatting issues.

Also, you've (accidentally?) resolved a few comments that weren't fixed.

include/zephyr/bluetooth/audio/bap.h

subsys/bluetooth/audio/bap_scan_delegator.c

include/zephyr/bluetooth/audio/bap.h

Kconfig option BT_BAP_SCAN_DELEGATOR_OVERWRITE_OLDEST allows the Scan Delegator to overwrite the oldest inactive receive state if there aren't any free receive states. A inactive receive state is a receive state that has neither a Periodic Advertising or Broadcast Isochronous Group (BIG) sync. There is also a recv_state_add_fail callback function added which can notify an application if all receive states are not inactive and can't be freed. Signed-off-by: Paul Mulligan <[email protected]>

Thalley · 2023-11-10T11:02:16Z

@pmullt Looks like it needs a rebase :)

github-actions · 2024-01-10T00:29:49Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

github-actions · 2024-03-20T00:29:48Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

pmullt requested review from jhedberg, Vudentz, Thalley, sjanc and alwa-nordic as code owners September 13, 2023 16:05

zephyrbot added area: Bluetooth Audio area: Bluetooth labels Sep 13, 2023

zephyrbot requested review from asbjornsabo, Casper-Bonde-Bose, fredrikdanebjer, hermabe, kruithofa, larsgk and MariuszSkamra September 13, 2023 16:06

zephyrbot assigned Thalley Sep 13, 2023

github-actions bot reviewed Sep 13, 2023

View reviewed changes

pmullt force-pushed the bap_scan_delegator_recv_state_overwrite branch 4 times, most recently from b94a48a to dafbba7 Compare September 14, 2023 11:19

Thalley requested changes Sep 18, 2023

View reviewed changes

pmullt force-pushed the bap_scan_delegator_recv_state_overwrite branch from dafbba7 to a8e7c9c Compare September 20, 2023 16:44

Thalley reviewed Sep 21, 2023

View reviewed changes

pmullt force-pushed the bap_scan_delegator_recv_state_overwrite branch 3 times, most recently from e9638e0 to 0157c3e Compare September 26, 2023 15:25

Thalley requested changes Sep 27, 2023

View reviewed changes

pmullt force-pushed the bap_scan_delegator_recv_state_overwrite branch 2 times, most recently from cc966f4 to 8b395bf Compare September 28, 2023 14:46

pmullt force-pushed the bap_scan_delegator_recv_state_overwrite branch 4 times, most recently from 9da387c to b1b66a0 Compare October 2, 2023 18:46

Thalley requested changes Oct 5, 2023

View reviewed changes

pmullt force-pushed the bap_scan_delegator_recv_state_overwrite branch from b1b66a0 to ecc1f79 Compare October 16, 2023 18:36

Thalley requested changes Oct 17, 2023

View reviewed changes

pmullt force-pushed the bap_scan_delegator_recv_state_overwrite branch from ecc1f79 to 76083d7 Compare October 18, 2023 09:12

Thalley requested changes Oct 18, 2023

View reviewed changes

pmullt force-pushed the bap_scan_delegator_recv_state_overwrite branch from 76083d7 to 9c8437c Compare October 18, 2023 19:15

Thalley requested changes Oct 20, 2023

View reviewed changes

pmullt force-pushed the bap_scan_delegator_recv_state_overwrite branch from 9c8437c to be1ecf6 Compare October 24, 2023 09:56

zephyrbot added the area: Samples Samples label Oct 24, 2023

zephyrbot requested a review from kartben October 24, 2023 09:57

pmullt force-pushed the bap_scan_delegator_recv_state_overwrite branch from be1ecf6 to 60c916e Compare October 24, 2023 10:05

Thalley requested changes Oct 30, 2023

View reviewed changes

pmullt force-pushed the bap_scan_delegator_recv_state_overwrite branch from 60c916e to 10b1548 Compare November 8, 2023 12:48

Thalley reviewed Nov 10, 2023

View reviewed changes

include/zephyr/bluetooth/audio/bap.h Outdated Show resolved Hide resolved

pmullt force-pushed the bap_scan_delegator_recv_state_overwrite branch from 10b1548 to a2f9362 Compare November 10, 2023 09:28

github-actions bot added the Stale label Jan 10, 2024

kruithofa removed their request for review January 19, 2024 09:58

github-actions bot removed the Stale label Jan 20, 2024

github-actions bot added the Stale label Mar 20, 2024

github-actions bot closed this Apr 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Option to overwrite a Receive State in the Scan Delegator #62609

Option to overwrite a Receive State in the Scan Delegator #62609

pmullt commented Sep 13, 2023

github-actions bot left a comment

Thalley left a comment

carlescufi commented Sep 28, 2023

Thalley left a comment

Thalley left a comment

Thalley Oct 17, 2023

Thalley left a comment

Thalley Oct 18, 2023

Thalley Oct 18, 2023

Thalley Oct 18, 2023

Thalley Oct 18, 2023

Thalley left a comment

Thalley commented Nov 10, 2023

github-actions bot commented Jan 10, 2024

github-actions bot commented Mar 20, 2024

		if (scan_delegator_cbs != NULL &&
		scan_delegator_cbs->recv_state_add_failed != NULL) {

		if (state->pa_sync_state == BT_BAP_PA_STATE_SYNCED \|\|
		state->pa_sync_state == BT_BAP_PA_STATE_INFO_REQ) {

		if ((oldest_inactive_state == NULL) \|\|
		(current_state->aging_counter < oldest_inactive_state->aging_counter)) {

		(void)memcpy(&state_info.subgroups, &param->subgroups,
		sizeof(state_info.subgroups));

		LOG_DBG("New source ID 0x%02x (%d) added to Scan Delegator at Index %u: ",
		state->src_id, state->src_id, internal_state->index);

Option to overwrite a Receive State in the Scan Delegator #62609

Option to overwrite a Receive State in the Scan Delegator #62609

Conversation

pmullt commented Sep 13, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

Thalley left a comment

Choose a reason for hiding this comment

carlescufi commented Sep 28, 2023

Thalley left a comment

Choose a reason for hiding this comment

Thalley left a comment

Choose a reason for hiding this comment

Thalley Oct 17, 2023

Choose a reason for hiding this comment

Thalley left a comment

Choose a reason for hiding this comment

Thalley Oct 18, 2023

Choose a reason for hiding this comment

Thalley Oct 18, 2023

Choose a reason for hiding this comment

Thalley Oct 18, 2023

Choose a reason for hiding this comment

Thalley Oct 18, 2023

Choose a reason for hiding this comment

Thalley left a comment

Choose a reason for hiding this comment

Thalley commented Nov 10, 2023

github-actions bot commented Jan 10, 2024

github-actions bot commented Mar 20, 2024