Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgmt: hawkbit: resume download of firmware #71954

Merged
merged 2 commits into from
Jan 9, 2025
Merged

mgmt: hawkbit: resume download of firmware #71954

merged 2 commits into from
Jan 9, 2025
+184 −91

Conversation

maass-hamburg
Copy link
Collaborator

@maass-hamburg maass-hamburg commented Apr 25, 2024 •
edited
Loading

Resolves: #71952

Depends on:

@maass-hamburg maass-hamburg force-pushed the hawkbit_resume_download branch 2 times, most recently from 6c5801b to c02643e Compare May 3, 2024 06:06
@maass-hamburg maass-hamburg force-pushed the hawkbit_resume_download branch from c02643e to 42e2600 Compare May 13, 2024 14:05
@github-actions GitHub Actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jul 13, 2024
@github-actions GitHub Actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Sep 12, 2024
@github-actions GitHub Actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Nov 12, 2024
@maass-hamburg maass-hamburg force-pushed the hawkbit_resume_download branch from 42e2600 to d10a791 Compare December 12, 2024 13:18
@maass-hamburg maass-hamburg force-pushed the hawkbit_resume_download branch from d10a791 to 18eea90 Compare December 21, 2024 20:18
@maass-hamburg maass-hamburg mentioned this pull request Dec 21, 2024
Merged
@maass-hamburg maass-hamburg force-pushed the hawkbit_resume_download branch from 18eea90 to 4981e32 Compare December 25, 2024 18:18
@maass-hamburg maass-hamburg marked this pull request as ready for review December 25, 2024 18:19
@maass-hamburg maass-hamburg added the DNM This PR should not be merged (Do Not Merge) label Dec 25, 2024
@zephyrbot zephyrbot requested review from kartben and nashif December 25, 2024 18:20
@maass-hamburg
Copy link
Collaborator Author

DNM added due to this PR being almost 8 month old and I want to test it again.

@kartben kartben assigned maass-hamburg and unassigned kartben Dec 25, 2024
@maass-hamburg maass-hamburg force-pushed the hawkbit_resume_download branch 2 times, most recently from 53fda41 to 4c10729 Compare January 8, 2025 08:40
@maass-hamburg
Copy link
Collaborator Author

Tested in hardware successful

@maass-hamburg
Copy link
Collaborator Author

Changed default of HAWKBIT_SAVE_PROGRESS_INTERVAL to 5, which means every 5% the download progress is saved, seems like a good balanced value, between not using the flash to much and saving the state often, to not having to lose to much progress.

@maass-hamburg maass-hamburg removed the DNM This PR should not be merged (Do Not Merge) label Jan 8, 2025
@maass-hamburg
Copy link
Collaborator Author

@de-nordic added you for review as you know a few things about STREAM_FLASH_PROGRESS and the hawkBit subsystem currently doesn't has any other maintainers and collaborators than me

@de-nordic de-nordic requested a review from nordicjm January 8, 2025 16:06
de-nordic
de-nordic previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK for me.

subsys/mgmt/hawkbit/hawkbit.c Show resolved Hide resolved
@de-nordic
Copy link
Collaborator

@nordicjm Adding you in case you have some input on the DFU here.

kartben
kartben reviewed Jan 9, 2025
View reviewed changes
subsys/mgmt/hawkbit/Kconfig Outdated Show resolved Hide resolved
@maass-hamburg
mgmt: hawkbit: resume firmware downloads
d5734b7 
save download progress, to resume failed
firmware downloads.

Signed-off-by: Fin Maaß <[email protected]>
@maass-hamburg
mgmt: hawkbit: add CONFIG_HAWKBIT_SAVE_PROGRESS_INTERVAL
0c51dd1 
add CONFIG_HAWKBIT_SAVE_PROGRESS_INTERVAL, to
be able to set a interval, how often the progress is saved.

Signed-off-by: Fin Maaß <[email protected]>
@maass-hamburg maass-hamburg force-pushed the hawkbit_resume_download branch from 4c10729 to 0c51dd1 Compare January 9, 2025 10:45
kartben
kartben approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool stuff! Really need to get that Zephyr Tech Talk about hawkBit+Zephyr on the books at some point 😄 🫣

@de-nordic de-nordic added this to the v4.1.0 milestone Jan 9, 2025
@kartben kartben merged commit 3c88970 into zephyrproject-rtos:main Jan 9, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@de-nordic de-nordic de-nordic approved these changes

@kartben kartben kartben approved these changes

@nashif nashif Awaiting requested review from nashif

@nordicjm nordicjm Awaiting requested review from nordicjm

Assignees

@maass-hamburg maass-hamburg

Labels
area: hawkBit area: Samples Samples
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

mgmt: hawkbit: Resume-able download, with download progress stored in flash
4 participants
@maass-hamburg @de-nordic @kartben @zephyrbot