-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: footprint: Add data transform and upload to ELK #78461
ci: footprint: Add data transform and upload to ELK #78461
Conversation
--run-attempt "${{ github.run_attempt }}" \ | ||
--run-workflow "footprint-tracking:${{ github.event_name }}" \ | ||
--run-branch "${{ github.ref_name }}" \ | ||
-i TODO_PUT_FOOTPRINT_INDEX_NAME_HERE \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index map file to create the ELK index:
https://github.com/zephyrproject-rtos/zephyr/pull/78435/files#diff-00bc8bfbe57474390b54a1b9561a6c4b1560cda3704dc0785935a17edf413786R140-R145
--run-attempt "${{ github.run_attempt }}" \ | ||
--run-workflow "footprint-tracking:${{ github.event_name }}" \ | ||
--run-branch "${{ github.ref_name }}" \ | ||
-i TODO_PUT_FOOTPRINT_INDEX_NAME_HERE \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nashif could you please clarify what index name to use here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use environment variable, like we do ELASTICSEARCH_SERVER
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to env. variable (note its value is assigned from my guess)
10158f8
to
271acbe
Compare
env: | ||
ELASTICSEARCH_KEY: ${{ secrets.ELASTICSEARCH_KEY }} | ||
ELASTICSEARCH_SERVER: "https://elasticsearch.zephyrproject.io:443" | ||
ELASTICSEARCH_INDEX: "zephyr-footprint-tracking" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
${{ vars.FOOTPRINT_TRACKING_INDEX }}
, see .github/workflows/stats_merged_prs.yml for an example where something similar is used.
Extend `footprint-tracking` CI workflow with two more steps: * pack Memory Footprint data produced by `track.py` script into Twister JSON footprint reports (`twister-footprint.json). * upload Twister JSON footprint reports into ElasticSearch storage. Signed-off-by: Dmitrii Golovanov <[email protected]>
271acbe
to
410a0c9
Compare
just to remind
|
--run-branch "${{ github.ref_name }}" \ | ||
-i ${ELASTICSEARCH_INDEX} \ | ||
./footprint_data/**/twister_footprint.json | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stray #
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#
is left to make clear the workflow step (and its last command) ends here.
let me know if it breaks CI or YAML conventions to remove it.
index was already created. |
Extend
footprint-tracking
CI workflow with two more steps:pack Memory Footprint data produced by
track.py
script into Twister JSON footprint reports (`twister-footprint.json).upload Twister JSON footprint reports into ElasticSearch storage.
Depends on: #76889, #77793, #78435.