Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: footprint: Add data transform and upload to ELK #78461

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

golowanow
Copy link
Member

Extend footprint-tracking CI workflow with two more steps:

  • pack Memory Footprint data produced by track.py script into Twister JSON footprint reports (`twister-footprint.json).

  • upload Twister JSON footprint reports into ElasticSearch storage.

Depends on: #76889, #77793, #78435.

--run-attempt "${{ github.run_attempt }}" \
--run-workflow "footprint-tracking:${{ github.event_name }}" \
--run-branch "${{ github.ref_name }}" \
-i TODO_PUT_FOOTPRINT_INDEX_NAME_HERE \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--run-attempt "${{ github.run_attempt }}" \
--run-workflow "footprint-tracking:${{ github.event_name }}" \
--run-branch "${{ github.ref_name }}" \
-i TODO_PUT_FOOTPRINT_INDEX_NAME_HERE \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nashif could you please clarify what index name to use here ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use environment variable, like we do ELASTICSEARCH_SERVER

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to env. variable (note its value is assigned from my guess)

@golowanow golowanow added the DNM This PR should not be merged (Do Not Merge) label Sep 26, 2024
@golowanow golowanow marked this pull request as ready for review September 26, 2024 08:28
@golowanow golowanow force-pushed the ci_footprint_elk_20240913 branch from 10158f8 to 271acbe Compare September 26, 2024 09:13
env:
ELASTICSEARCH_KEY: ${{ secrets.ELASTICSEARCH_KEY }}
ELASTICSEARCH_SERVER: "https://elasticsearch.zephyrproject.io:443"
ELASTICSEARCH_INDEX: "zephyr-footprint-tracking"
Copy link
Member

@nashif nashif Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${{ vars.FOOTPRINT_TRACKING_INDEX }}, see .github/workflows/stats_merged_prs.yml for an example where something similar is used.

Extend `footprint-tracking` CI workflow with two more steps:

 * pack Memory Footprint data produced by `track.py` script
   into Twister JSON footprint reports (`twister-footprint.json).

 * upload Twister JSON footprint reports into ElasticSearch storage.

Signed-off-by: Dmitrii Golovanov <[email protected]>
@golowanow golowanow force-pushed the ci_footprint_elk_20240913 branch from 271acbe to 410a0c9 Compare September 26, 2024 09:19
@nashif nashif removed the DNM This PR should not be merged (Do Not Merge) label Sep 26, 2024
@golowanow
Copy link
Member Author

--run-branch "${{ github.ref_name }}" \
-i ${ELASTICSEARCH_INDEX} \
./footprint_data/**/twister_footprint.json
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray #?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# is left to make clear the workflow step (and its last command) ends here.
let me know if it breaks CI or YAML conventions to remove it.

@nashif
Copy link
Member

nashif commented Sep 26, 2024

just to remind

index map file to create the ELK index: #78435 (files)

index was already created.

@nashif nashif merged commit e528d53 into zephyrproject-rtos:main Oct 17, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants