Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest: Update LittleFS #79436

Closed
wants to merge 1 commit into from
Closed

manifest: Update LittleFS #79436

wants to merge 1 commit into from

Conversation

Jappie3
Copy link

@Jappie3 Jappie3 commented Oct 4, 2024

@Jappie3 Jappie3 mentioned this pull request Oct 4, 2024
Merged
@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Hello @Jappie3, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@zephyrbot
Copy link
Collaborator

zephyrbot commented Oct 4, 2024 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
littlefs zephyrproject-rtos/littlefs@424a5e0 zephyrproject-rtos/littlefs#15 zephyrproject-rtos/littlefs#15/files

Additional metadata changed:

Name URL Submodules West cmds module.yml
littlefs ✏

⛔ DNM label due to: 1 project with PR revision and 1 project with metadata changes

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-littlefs DNM This PR should not be merged (Do Not Merge) labels Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Dec 4, 2024
@Jappie3
Copy link
Author

Jappie3 commented Dec 11, 2024

still relevant

@github-actions github-actions bot removed the Stale label Dec 12, 2024
@kartben kartben mentioned this pull request Jan 17, 2025
Merged
@de-nordic de-nordic self-requested a review January 17, 2025 19:39
@de-nordic de-nordic self-assigned this Jan 17, 2025
@de-nordic
Copy link
Collaborator

still relevant

@Jappie3 Sorry for lagging. Can you please rebase?

@de-nordic de-nordic requested review from kartben and nashif January 17, 2025 19:40
@Jappie3
Copy link
Author

Jappie3 commented Jan 18, 2025

@de-nordic no worries!
rebased

@de-nordic
Copy link
Collaborator

@de-nordic no worries!

rebased

Please check compliance error messages and address issues.

@Jappie3
Copy link
Author

Jappie3 commented Jan 18, 2025

fixed I think

@kartben
Copy link
Collaborator

kartben commented Jan 18, 2025

fixed I think

https://github.com/zephyrproject-rtos/zephyr/actions/runs/12845612429/job/35821291559#step:12:46

@Jappie3
manifest: Update LittleFS
b615b04 
The LittleFS module name is now explicitly set in zephyr/module.yml. This
ensures that building with e.g. cmake does not fail when the directory name is
different. When managing dependencies with West, this should be taken care
of automatically.

Signed-off-by: Jappie3 <[email protected]>
@Jappie3
Copy link
Author

Jappie3 commented Jan 18, 2025

apologies, I assumed signed-off counted as body text
try again

@kartben
Copy link
Collaborator

kartben commented Jan 18, 2025

apologies, I assumed signed-off counted as body text
try again

Please do read all the error messages :)
You need to use your legal name for the sign off, as well as git author (and naturally, they must match)

@Jappie3
Copy link
Author

Jappie3 commented Jan 18, 2025

yeaaaah I don't feel like using my real name on here, sorry guys
thanks for your time

@Jappie3 Jappie3 closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@de-nordic de-nordic Awaiting requested review from de-nordic

@kartben kartben Awaiting requested review from kartben

@nashif nashif Awaiting requested review from nashif

Assignees

@de-nordic de-nordic

Labels
DNM This PR should not be merged (Do Not Merge) manifest manifest-littlefs size: XS A PR changing only a single line of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jappie3 @zephyrbot @de-nordic @kartben