Add support PWM EMIOS for S32Z270 #79532
Merged
+681
−268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: PWM
zephyrbot
requested review from
anangl,
bperseghetti,
henrikbrixandersen and
PetervdPerk-NXP
Dat-NguyenDuy
force-pushed
the
s32ze-pwm-emios
branch
from
72d347f to
c8bb6ec
Compare
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nxp
DNM
Dat-NguyenDuy
force-pushed
the
s32ze-pwm-emios
branch
from
c8bb6ec to
cff126e
Compare
Dat-NguyenDuy
force-pushed
the
s32ze-pwm-emios
branch
from
cff126e to
101aa44
Compare
|
Rebased to fix conflict |
Dat-NguyenDuy
force-pushed
the
s32ze-pwm-emios
branch
from
101aa44 to
6274839
Compare
|
Looks good, should be ready to merge when manifest update points to a sha :) |
manuargue
previously approved these changes
Dec 18, 2024
mmahadevan108
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Needs to be sequenced behind #81113
@Dat-NguyenDuy I merged the HAL side. After the gating PR merges, then we can updatr the HAL SHA and I'll clear my CR
Yep, np. Thanks. |
Removing period, duty and polarity configuration from channel devicetree. At boot time, only minimal setup like pinctrl, prescaler, etc should be initialized. PWM signal is produced by using pwm_set* API Also after this change, PWM period, duty are changed at the next counter period boundary Signed-off-by: Dat Nguyen Duy <[email protected]>
This adds support PWM EMIOS for NXP S32Z SoC, both PWM pulse generate and pulse capture are supported Signed-off-by: Dat Nguyen Duy <[email protected]>
Add support PWM eMIOS for s32z2xxdc2 board. There is no LED on-board dedicated for PWM, so no sample is supported. Only enabling some pwm tests Signed-off-by: Dat Nguyen Duy <[email protected]>
mmahadevan108
force-pushed
the
s32ze-pwm-emios
branch
from
6274839 to
5a1650c
Compare
mmahadevan108
approved these changes
Jan 17, 2025
|
Updated to pull in the changes from the HAL. |
|
@bjarki-andreasen , can you please review one more time. |
bjarki-andreasen
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, this remove period, duty cycle and polarity configuration from emios channel devicetree. PWM signal is produced only when pwm_set* API is called. Then adds support PWM EMIOS for S32Z270 and enables its usage for board s32z270dc2.
Tested on
tests\drivers\pwm_apiandtests\drivers\pwm_loopback