arch: arm: cortex_m: pm_s2ram: fix system_off rv as rv of s2ram_suspend #80642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
bbolen,
carlocaione,
galak,
ithinuel,
MaureenHelm,
microbuilder and
stephanosio
stephanosio
reviewed
Oct 31, 2024
The return value of the system_off call is overwritten by the the call to pm_s2ram_mark_check_and_clear. As arch_pm_s2ram_suspend needs to specify why system_off failed, we need to make sure the rv of system_off is moved to a safe register before calling pm_s2ram_mark_check_and_clear and moved to r0 als rv of arch_pm_s2ram_suspend when the suspend call exits. Signed-off-by: Hessel van der Molen <[email protected]>
HesselM
force-pushed
the
main-zephyr_pr-s2ram_stack_systemoff
branch
from
af3877c to
30588e2
Compare
mathieuchopstm
approved these changes
Nov 5, 2024
Comment on lines
+98
to
+100
| /* Move the stored return value of system_off back to r0, | ||
| * setting it as return value for this function. | ||
| */ |
There was a problem hiding this comment.
Nit:
Suggested change
| /* Move the stored return value of system_off back to r0, | |
| * setting it as return value for this function. | |
| */ | |
| /* | |
| * Move the stored return value of system_off back to r0, | |
| * setting it as return value for this function. | |
| */ |
ithinuel
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug with overwriting the r0 register, introduced by #77277