drivers: flash: sam: fix flash erase last page #80800
Open
+50
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation for erasing pages in the flash_sam.c driver indicated a successful erase after exceeding the last page to be erased successfully. Since the last page has no proceeding page, the succeeded status was not set. This fix switches around the status to be set as succeeded before erase begins, to have the succeeded status cleared if page unlock or erase fails. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
added
bug
zephyrbot
added
area: Flash
platform: Microchip SAM
|
|
zephyrbot
requested review from
attie-argentum,
de-nordic,
mnkp,
nandojve,
pdgendt,
rghaddab and
stephanosio
de-nordic
previously approved these changes
Dec 16, 2024
|
Hardware tests on sam_v71_xult/samv71q21. |
|
The current tests with the samv71 partition cover the last page? If yes, I'm ready to approve. |
|
To erase the last page for that board, change this line toDT_NODELABEL(scratch_partition) and run the suite again :) we are looking for:
the board has a scratch partition at the end of the flash area :) |
I can do that and provide feedback, yes. But in this case, it will be nice if we extend the test to run over these two partitions. I want to avoid regressions here. I'm fine if you want to do on another PR too to not switch your tasks at moment. |
|
Running test using the scratch_partition |
|
well that sucks :) |
|
Hi @bjarki-andreasen , I was wondering if you had time to look on it again. |
|
friendly ping : ) |
|
I'm getting a dev kit in the coming days, then I will fix it properly |
Add default partition table used with common apps like test suites and the bootloader. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
To fully test the flash controllers, the test suite should erase the very first pages, and the very last page to find bugs in the extremes. Using an overlay to update the partition layout to extend slot1 to the end makes this possible. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
|
I extended the test suite to include board overlays so we can adjust the slot1 partition to extend to the very end of the flash area. With this, and running the test suite both with and without MCU boot on an sam4e_xpro, it runs without error, erasing the last page successfully: I did not need to change the driver, from what I can tell the bug was indeed fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation for erasing pages in the flash_sam.c driver indicated a successful erase after exceeding the last page to be erased successfully. Since the last page has no proceeding page, the succeeded status was not set.
This fix switches around the status to be set as succeeded before erase begins, to have the succeeded status cleared if page unlock or erase fails.
fixes: #70344