Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KW45 SoC, and KW45B41-EVK board support #82034

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sumitbatra-nxp
Copy link
Contributor

@sumitbatra-nxp sumitbatra-nxp commented Nov 26, 2024

There are 2 commits in this PR -

  1. Adds KW45 SoC Family support
  2. Adds KW45B41Z-EVK board support

This PR is dependent on a HAL PR - zephyrproject-rtos/hal_nxp#476

@zephyrbot
Copy link
Collaborator

zephyrbot commented Nov 26, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@cae4002 zephyrproject-rtos/hal_nxp#476 zephyrproject-rtos/hal_nxp#476/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added the DNM This PR should not be merged (Do Not Merge) label Nov 26, 2024
@sjanc sjanc removed their request for review November 26, 2024 10:26
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two commits should really be two different PRs
What's more, the comments I made in #81559 need to be addressed, in particular the lack of copyright notices for the third party code

@Thalley Thalley removed their request for review November 26, 2024 12:10
@@ -0,0 +1,8 @@
# Copyright 2024 NXP
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs splitting up into multiple commits, one for adding soc, one for adding board, one for making test changes

Copy link
Contributor Author

@sumitbatra-nxp sumitbatra-nxp Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.. but based on kartben's comment I am planning to create another PR for OpenDroneID App.
SoC and board changes can be tested with - samples/bluetooth/beacon or any other existing test apps

@sumitbatra-nxp
Copy link
Contributor Author

sumitbatra-nxp commented Nov 27, 2024

The two commits should really be two different PRs What's more, the comments I made in #81559 need to be addressed, in particular the lack of copyright notices for the third party code

@kartben .. Fixed #81559..
Wanted to ask if you agree on -

  1. Splitting this PR into 2 commits one for SoC support and another one for board
  2. For creating a separate PR for OpendroneID application since it will be dependent on this PR, I can mark PR2 as do not merge until PR1 is merged

@sumitbatra-nxp sumitbatra-nxp changed the title KW45 SoC, board support with OpendroneID Application KW45 SoC, and KW45B41-EVK board support Nov 27, 2024
Comment on lines +44 to +46
sjw:
type: int
description: Resynchronization jump width (ISO 11898-1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth area: Boards area: CAN area: Samples Samples area: SPI SPI bus DNM This PR should not be merged (Do Not Merge) manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants