-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KW45 SoC, and KW45B41-EVK board support #82034
base: main
Are you sure you want to change the base?
KW45 SoC, and KW45B41-EVK board support #82034
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two commits should really be two different PRs
What's more, the comments I made in #81559 need to be addressed, in particular the lack of copyright notices for the third party code
@@ -0,0 +1,8 @@ | |||
# Copyright 2024 NXP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs splitting up into multiple commits, one for adding soc, one for adding board, one for making test changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.. but based on kartben's comment I am planning to create another PR for OpenDroneID App.
SoC and board changes can be tested with - samples/bluetooth/beacon or any other existing test apps
96856fb
to
9563ef2
Compare
9563ef2
to
35d49ce
Compare
@kartben .. Fixed #81559..
|
9689ae8
to
c700dbf
Compare
Signed-off-by: Sumit Batra <[email protected]>
Signed-off-by: Sumit Batra <[email protected]>
c700dbf
to
27dc604
Compare
sjw: | ||
type: int | ||
description: Resynchronization jump width (ISO 11898-1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this added?
There are 2 commits in this PR -
This PR is dependent on a HAL PR - zephyrproject-rtos/hal_nxp#476