Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a sysbuild failure for M5Stack CoreS3 #83294

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

soburi
Copy link
Member

@soburi soburi commented Dec 21, 2024

This is caused by a driver whose dependencies cannot be resolved being included during sysbuild.

mfd_aw9523b, gpi_aw9523b: Replace 'select I2C' with 'depends on I2C' in Kconfig to follow the specified build settings.

ft5336: Enables INPUT under stricter conditions (when LVGL or DISPLAY is enabled).

@soburi soburi changed the title Cores3 fix sysbuild Fix failure of M5Stack CoreS3 sysbuild Dec 21, 2024
@soburi soburi added the bug The issue is a bug, or the PR is fixing a bug label Dec 21, 2024
@soburi soburi changed the title Fix failure of M5Stack CoreS3 sysbuild Fixes a sysbuild failure for M5Stack CoreS3 Dec 21, 2024
@soburi soburi force-pushed the cores3_fix_sysbuild branch 2 times, most recently from 9777c0a to 85d680b Compare December 21, 2024 04:40
@soburi soburi marked this pull request as ready for review December 21, 2024 07:02
@soburi soburi self-assigned this Dec 21, 2024
@@ -9,6 +9,6 @@ config INPUT_FT5336_INTERRUPT
default y if INPUT

config INPUT
default y
default y if LVGL || DISPLAY
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be also addressed for m5stack_core2 board?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On CoreS3/CoreS3SE, the I2C-connected GPIO Expander AW9523B is connected to various parts of the system, so it should be enabled at all times, but this enables I2C, which causes a conflict with the mcuboot settings.
On Core2, there is no GPIO Expander, so no problems occur.

@@ -5,3 +5,5 @@ CONFIG_CONSOLE=y
CONFIG_SERIAL=y
CONFIG_UART_CONSOLE=y
CONFIG_GPIO=y
CONFIG_I2C=y
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CONFIG_I2C=y isn't necessary as it is automatically added when enabled in DTS file. Can you confirm whether you need this here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comment.

I found the correct way to fix it.
The device can be disabled in the MCUBoot settings, so I changed it to deal with the problem that way.

@soburi soburi force-pushed the cores3_fix_sysbuild branch from 85d680b to 7d09d89 Compare December 22, 2024 22:44
@zephyrbot
Copy link
Collaborator

zephyrbot commented Dec 22, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
mcuboot zephyrproject-rtos/mcuboot@a2bc982 (main,upstream-sync) ❌ Impostor SHA: zephyrproject-rtos/mcuboot@95773ed zephyrproject-rtos/[email protected]

DNM label due to: 1 impostor SHA

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-mcuboot DNM This PR should not be merged (Do Not Merge) labels Dec 22, 2024
nordicjm
nordicjm previously approved these changes Dec 23, 2024
sylvioalves
sylvioalves previously approved these changes Dec 23, 2024
@kartben
Copy link
Collaborator

kartben commented Jan 18, 2025

@soburi please update manifest with final sha

Add this to disable on mcuboot.

Signed-off-by: TOKITA Hiroshi <[email protected]>
Introduce the update for the mcuboot configuration to fix
M5Stack CoreS3/CoreS3SE sysbuild failure.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi soburi dismissed stale reviews from sylvioalves and henrikbrixandersen via 066dc04 January 19, 2025 11:02
@soburi
Copy link
Member Author

soburi commented Jan 19, 2025

@kartben

@soburi please update manifest with final sha

zephyrproject-rtos/mcuboot#122

I will remove DNM after this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: GPIO area: MFD bug The issue is a bug, or the PR is fixing a bug DNM This PR should not be merged (Do Not Merge) manifest manifest-mcuboot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants