-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes a sysbuild failure for M5Stack CoreS3 #83294
base: main
Are you sure you want to change the base?
Conversation
9777c0a
to
85d680b
Compare
@@ -9,6 +9,6 @@ config INPUT_FT5336_INTERRUPT | |||
default y if INPUT | |||
|
|||
config INPUT | |||
default y | |||
default y if LVGL || DISPLAY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be also addressed for m5stack_core2
board?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On CoreS3/CoreS3SE, the I2C-connected GPIO Expander AW9523B is connected to various parts of the system, so it should be enabled at all times, but this enables I2C, which causes a conflict with the mcuboot settings.
On Core2, there is no GPIO Expander, so no problems occur.
@@ -5,3 +5,5 @@ CONFIG_CONSOLE=y | |||
CONFIG_SERIAL=y | |||
CONFIG_UART_CONSOLE=y | |||
CONFIG_GPIO=y | |||
CONFIG_I2C=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think CONFIG_I2C=y
isn't necessary as it is automatically added when enabled in DTS file. Can you confirm whether you need this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your comment.
I found the correct way to fix it.
The device can be disabled in the MCUBoot settings, so I changed it to deal with the problem that way.
85d680b
to
7d09d89
Compare
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 impostor SHA Note: This message is automatically posted and updated by the Manifest GitHub Action. |
@soburi please update manifest with final sha |
Add this to disable on mcuboot. Signed-off-by: TOKITA Hiroshi <[email protected]>
Introduce the update for the mcuboot configuration to fix M5Stack CoreS3/CoreS3SE sysbuild failure. Signed-off-by: TOKITA Hiroshi <[email protected]>
066dc04
7d09d89
to
066dc04
Compare
zephyrproject-rtos/mcuboot#122 I will remove DNM after this PR is merged. |
This is caused by a driver whose dependencies cannot be resolved being included during sysbuild.
mfd_aw9523b, gpi_aw9523b: Replace 'select I2C' with 'depends on I2C' in Kconfig to follow the specified build settings.
ft5336: Enables INPUT under stricter conditions (when LVGL or DISPLAY is enabled).