Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate mimxrt1050_evk and mimxrt1060_evk boards properly and update mcuboot #83296

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

kartben
Copy link
Collaborator

@kartben kartben commented Dec 21, 2024

  • add proper deprecation for mimxrt1050_evk, mimxrt1060_evk and mimxrt1060_evkb
  • pull new version of mcuboot that drops old name references in sample.yaml file (twister doesn't seem to know about deprecated names so this change is actually required)

The changes to the deprecated.cmake are not strictly required as part of the hotfix but since I'd already done it when realizing twister didn't really use that file, I thought it was worthwhile to keep since it's needed anyway to not break users downstream.

Reference for the renames that happened to help reviewers ensure no mistakes were made

@kartben kartben added the Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. label Dec 21, 2024
@zephyrbot
Copy link
Collaborator

zephyrbot commented Dec 21, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
mcuboot zephyrproject-rtos/mcuboot@f5454f1 zephyrproject-rtos/mcuboot@a2bc982 (main,upstream-sync) zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-mcuboot DNM This PR should not be merged (Do Not Merge) labels Dec 21, 2024
…ames

Add required entries so that old names can still be used for the time
being.

Signed-off-by: Benjamin Cabé <[email protected]>
west.yml Outdated Show resolved Hide resolved
Make sure CI can properly run on bootloader module by pulling
the mcuboot version that has correct names for the mimxrt1050/60
platforms.

Signed-off-by: Benjamin Cabé <[email protected]>
@kartben kartben marked this pull request as ready for review December 21, 2024 18:27
@kartben kartben requested review from dleach02 and decsny December 21, 2024 18:27
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Dec 21, 2024
@kartben kartben requested a review from a team December 21, 2024 19:13
@kartben kartben merged commit 73f55a6 into zephyrproject-rtos:main Dec 21, 2024
27 of 28 checks passed
@kartben kartben deleted the mimx branch January 15, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. manifest manifest-mcuboot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants