boards: esp32c3_supermini: increase board heap and stack #83514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The heap and stack are now consistent with other ESP32-C3 boards in tree. This is necessary for Bluetooth to not crash on boot. Signed-off-by: Xudong Zheng <[email protected]>
|
@sylvioalves wonder if this really has to do with the board per se or if this is basically a tell that it should be dealt with at the soc level if all boards end up needing the exact same config? |
|
It looks like the other board sets the CONFIG_MAIN_STACK_SIZE and heap size too. LGTM |
marekmatej
approved these changes
Jan 7, 2025
It might be the case it could be improved indeed, either by adding more HEAP when BLE is enabled or at SoC level. I am not able to submit a PR performing the necessary tests, so I am good having this merged. |
sylvioalves
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The heap and stack are now consistent with other ESP32-C3 boards in tree. This is necessary for Bluetooth to not crash on boot.