Bluetooth: TMAP: Remove double definitions of TMAP roles support #83540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjanc
reviewed
Jan 3, 2025
subsys/bluetooth/audio/shell/tmap.c
Outdated
| (BT_TMAP_UMR_SUPPORTED ? BT_TMAP_ROLE_UMR : 0U) | | ||
| (BT_TMAP_BMS_SUPPORTED ? BT_TMAP_ROLE_BMS : 0U) | | ||
| (BT_TMAP_BMR_SUPPORTED ? BT_TMAP_ROLE_BMR : 0U); | ||
| const enum bt_tmap_role role = (CONFIG_BT_TMAP_CG_SUPPORTED ? BT_TMAP_ROLE_CG : 0U) | |
There was a problem hiding this comment.
those should use IS_ENABLED() since otherwise CONFIG_FOO might be unset
Both the TMAP kconfig file and public header file defined which roles were supported. The Kconfig file options were recently added and were more up to date (and correct), and allows for other Kconfig files to use these values, thus allowing for more flexibility when implementing applications. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
tmap_rm_dual_roles
branch
from
dbd3524 to
0c2add6
Compare
zephyrbot
added
area: Bluetooth Qualification
zephyrbot
requested review from
asbjornsabo,
babrsn,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
jthm-ot,
kruithofa,
larsgk,
MariuszSkamra,
niym-ot and
pin-zephyr
sjanc
approved these changes
Jan 4, 2025
alexsven
approved these changes
Jan 8, 2025
fredrikdanebjer
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the TMAP kconfig file and public header file defined which roles were supported.
The Kconfig file options were recently added and were more up to date (and correct), and allows for other Kconfig files to use these values, thus allowing for more flexibility when implementing applications.