kconfig: Don't USE_DT_CODE_PARTITION if there isn't one #83877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @maass-hamburg! I'll keep an eye on your PR, looks like it's close to being merged. |
|
Rebase, after #83941 is fixed |
Previously, if there was no `zephyr,code-partition` chosen DT node, then enabling CONFIG_USE_DT_CODE_PARTITION would make all of flash available to the linker, with no immediate indication of that to the user. To avoid this discrepancy, make the USE_DT_CODE_PARTITION Kconfig symbol depend on that chosen node being present. For the sake of verbosity, add a dedicated symbol to describe this: HAS_DT_CODE_PARTITION. An additional benefit is that certain platforms or applications can now use `select USE_DT_CODE_PARTITION` to signal `zephyr,code-partition` as a hard requirement, by failing the build whenever the node is missing. Signed-off-by: Grzegorz Swiderski <[email protected]>
57300
force-pushed
the
has-dt-code-partition
branch
from
8f89db7 to
00bb3ca
Compare
maass-hamburg
approved these changes
Jan 17, 2025
pdgendt
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if there was no
zephyr,code-partitionchosen DT node, then enabling CONFIG_USE_DT_CODE_PARTITION would make all of flash available to the linker, with no immediate indication of that to the user.To avoid this discrepancy, make the USE_DT_CODE_PARTITION Kconfig symbol depend on that chosen node being present. For the sake of verbosity, add a dedicated symbol to describe this: HAS_DT_CODE_PARTITION.
An additional benefit is that certain platforms or applications can now use
select USE_DT_CODE_PARTITIONto signalzephyr,code-partitionas a hard requirement, by failing the build whenever the node is missing.