nRF54L: Add new entropy driver based on the CRACEN HW #83972

aescolar · 2025-01-14T16:13:01Z

Add new entropy driver based on the CRACEN HW, and the incoming (in a PR) CRACEN CTR DRBG driver.
It also pulls new HW models to be able to use it and test it in simulation.

Note: The PR points the nRF HW models to a branch where the new HAL is forcefully enabled (ahead of its release).

zephyrbot · 2025-01-14T16:14:14Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_nordic	zephyrproject-rtos/hal_nordic@`ecea8cd` (`master`)	zephyrproject-rtos/hal_nordic#272	zephyrproject-rtos/hal_nordic#272/files
nrf_hw_models	zephyrproject-rtos/nrf_hw_models@`71bcaa8`	zephyrproject-rtos/nrf_hw_models@`f6d4d3f` (`zephyr_2025_01_14`)	zephyrproject-rtos/[email protected]

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

frkv · 2025-01-15T09:35:49Z

dts/bindings/rng/nordic,nrf54lcracen-ctrdrbg.yaml

+# SPDX-License-Identifier: Apache-2.0
+
+description: |
+    Nordic nRF54L CRACEN CTR DRBG based (Random Number Generator)


Suggested change

Nordic nRF54L CRACEN CTR DRBG based (Random Number Generator)

Nordic nRF54L CRACEN CTR_DRBG based (Random Number Generator)

CTR_DRBG is the correct naming convention according to NIST SP800-90A

frkv · 2025-01-15T09:36:22Z

drivers/entropy/Kconfig.nrf54l_cracen

+# SPDX-License-Identifier: Apache-2.0
+
+config ENTROPY_NRF54LCRACEN_CTRDRBG
+	bool "nRF54L entropy driver based on the CRACEN CTR DRBG driver"


Suggested change

bool "nRF54L entropy driver based on the CRACEN CTR DRBG driver"

bool "nRF54L entropy driver based on the CRACEN CTR_DRBG driver"

CTR_DRBG is the correct naming convention according to NIST SP800-90A

I guess all CTRDRBG and ctrdrbg be CTR_DRBG and ctr_drbg, too?

AFAIK we cannot have "_" in DTS names. Anyhow, the name is long enough, so I hope it is ok without it there :)

cvinayak · 2025-01-15T11:58:00Z

drivers/entropy/Kconfig.nrf54l_cracen

+# SPDX-License-Identifier: Apache-2.0
+
+config ENTROPY_NRF54LCRACEN_CTRDRBG
+	bool "nRF54L entropy driver based on the CRACEN CTR DRBG driver"


I guess all CTRDRBG and ctrdrbg be CTR_DRBG and ctr_drbg, too?

cvinayak · 2025-01-15T11:58:53Z

subsys/bluetooth/controller/Kconfig.ll_sw_split

rettichschnidi · 2025-01-16T15:30:21Z

At Gardena, @cmair will test this PR using an internal prototype. Since he is not (yet?) part of the Zephyr organization, he will give feedback himself, but I'll approve the PR in his name.

Update with the latest nordic hal Signed-off-by: Alberto Escolar Piedras <[email protected]>

Update the HW models module to: 1069743a7fc06362e8f8d7f57225b8c7940da9f0 Including the following: 1069743 Fix in cracen hal conditional compile condition 3bbd3bd Enable build of hal/nrf_cracen_*.c 506da1f hal cracen_cm: Add const to prototype b02d927 BLECrypt_if: For new aes_ecb scramble data if no libCrypto e41f101 RRAMC nrf hal: Add replacements for new incoming RRAM APIs 4e933cf UART: Do not warn on invalid/unconfigured framesize 716b20c hal cracen_cm: Add replacements for new cracen_cm hal fc597a4 CRACEN: Add CryptoMaster & CM AES (ECB only) 129f16c CRACEN RNG HAL: Remove senseless static inline Signed-off-by: Alberto Escolar Piedras <[email protected]>

Update the HW models to the provisional branch zephyr_2025_01_14 which enables the use the not yet released CRACEN RNG & CM HAL Signed-off-by: Alberto Escolar Piedras <[email protected]>

Add support for the new nrf hal CRACEN CTR DRBG driver including a new kconfig option to enable it. Signed-off-by: Alberto Escolar Piedras <[email protected]>

Add a new entropy driver based on the nrf HAL CRACEN CTR DRBG driver Signed-off-by: Alberto Escolar Piedras <[email protected]>

Let's default to this new driver. And therefore change the conditions in the BT controller kconfig which were selecting the native_posix fake entropy driver Signed-off-by: Alberto Escolar Piedras <[email protected]> (f) boards nrf54l15bsim: Default to new cracen rng driver

Switch the default entropy driver for 54L05/10/15 devices to the new CRACEN based one. Signed-off-by: Alberto Escolar Piedras <[email protected]>

Use the new entropy driver for 54L devices and therefore claim BT_CTLR_ENTROPY_SUPPORT is always supported (note 54H remains unsuported) Signed-off-by: Alberto Escolar Piedras <[email protected]>

masz-nordic · 2025-01-17T16:21:46Z

modules/hal_nordic/nrfx/Kconfig

@@ -25,6 +25,10 @@ config NRFX_COMP
 	bool "COMP driver"
 	depends on $(dt_has_compat,$(DT_COMPAT_NORDIC_NRF_COMP))

+config NRFX_CRACEN
+	bool "CRACEN drivers"
+	depends on SOC_COMPATIBLE_NRF54LX


Should depend on DT.

There is no device tree node today for cracen itself. I could create one, but it really is just extra steps.

masz-nordic · 2025-01-17T16:24:46Z

dts/bindings/rng/nordic,nrf54lcracen-ctrdrbg.yaml

+    This driver is only compatible with 54L devices, and may only be used from one processor
+    core. This driver cannot be used in conjunction with the nRF security PSA solution, as both
+    would attempt to use the CRACEN HW exclusively; When that is enabled, zephyr,psa-crypto-rng
+    should be selected instead.


Not sure if driver constraints should be included in binding description.
Perhaps it would be better to note that this node is used to describe a subset of CRACEN resources, ie. CRACEN TRNG and CryptoMaster.

Perhaps it would be better to note that this node is used to describe a subset of CRACEN resources, ie. CRACEN TRNG and CryptoMaster.

This binding is used to describe the CTR_DRBG itself. Not the TRNG or Cryptomaster.

masz-nordic · 2025-01-17T16:25:49Z

dts/bindings/rng/nordic,nrf54lcracen-ctrdrbg.yaml

+    would attempt to use the CRACEN HW exclusively; When that is enabled, zephyr,psa-crypto-rng
+    should be selected instead.
+
+compatible: "nordic,nrf54lcracen-ctrdrbg"


Suggested change

compatible: "nordic,nrf54lcracen-ctrdrbg"

compatible: "nordic,cracen-ctrdrbg"

masz-nordic · 2025-01-17T16:28:08Z

drivers/entropy/entropy_nrf54l_cracen.c

Should be renamed to drivers/entropy/entropy_nrfx_cracen.c and namespaces aligned.

masz-nordic · 2025-01-17T16:29:09Z

drivers/entropy/Kconfig.nrf54l_cracen

+	bool "nRF54L entropy driver based on the CRACEN CTR_DRBG driver"
+	default y
+	depends on DT_HAS_NORDIC_NRF54LCRACEN_CTRDRBG_ENABLED
+	depends on SOC_COMPATIBLE_NRF54LX


Suggested change

depends on SOC_COMPATIBLE_NRF54LX

zephyrbot added manifest manifest-hal_nordic manifest-nrf_hw_models DNM This PR should not be merged (Do Not Merge) labels Jan 14, 2025

aescolar force-pushed the cracen_rng branch from 1d65eda to 56a7ce1 Compare January 14, 2025 16:14

aescolar requested a review from anangl January 14, 2025 16:16

aescolar force-pushed the cracen_rng branch 3 times, most recently from e3b2096 to 74e9b52 Compare January 15, 2025 09:14

carlescufi requested a review from rettichschnidi January 15, 2025 09:21

frkv reviewed Jan 15, 2025

View reviewed changes

cvinayak reviewed Jan 15, 2025

View reviewed changes

aescolar force-pushed the cracen_rng branch 2 times, most recently from 4725e07 to 9467542 Compare January 15, 2025 13:54

aescolar marked this pull request as ready for review January 16, 2025 10:01

zephyrbot added area: Bluetooth Controller platform: nRF Nordic nRFx platform: nRF BSIM Nordic Semiconductors, nRF BabbleSim area: Crypto / RNG area: Bluetooth labels Jan 16, 2025

zephyrbot requested review from carlescufi, ceolin, hubertmis, jaz1-nordic, kl-cruz, magp-nordic, masz-nordic and nika-nordic January 16, 2025 10:02

zephyrbot requested review from nordic-krch and tomi-font January 16, 2025 10:02

zephyrbot assigned ceolin Jan 16, 2025

aescolar force-pushed the cracen_rng branch from 9467542 to 9089e38 Compare January 17, 2025 08:24

carlescufi requested review from frkv and cvinayak January 17, 2025 10:09

aescolar added 3 commits January 17, 2025 13:34

manifest: Update hal_nordic with new cracen hal and rng driver

5f012cb

Update with the latest nordic hal Signed-off-by: Alberto Escolar Piedras <[email protected]>

manifest: Update nRF hw models to enable cracen HAL

721cb5c

Update the HW models to the provisional branch zephyr_2025_01_14 which enables the use the not yet released CRACEN RNG & CM HAL Signed-off-by: Alberto Escolar Piedras <[email protected]>

aescolar force-pushed the cracen_rng branch from 9089e38 to f423669 Compare January 17, 2025 12:35

aescolar added 5 commits January 17, 2025 15:30

modules: hal_nordic: Support new CRACEN CTR DRBG driver

b2d31bf

Add support for the new nrf hal CRACEN CTR DRBG driver including a new kconfig option to enable it. Signed-off-by: Alberto Escolar Piedras <[email protected]>

drivers: entropy: Add new driver based on nrf54l cracen driver

8534461

Add a new entropy driver based on the nrf HAL CRACEN CTR DRBG driver Signed-off-by: Alberto Escolar Piedras <[email protected]>

soc: nordic: nrf54L: Switch default entropy driver to new CRACEN one

b2c3ec8

Switch the default entropy driver for 54L05/10/15 devices to the new CRACEN based one. Signed-off-by: Alberto Escolar Piedras <[email protected]>

Bluetooth: Controller: Use cracen entropy driver for 54L devices

d17dbdf

Use the new entropy driver for 54L devices and therefore claim BT_CTLR_ENTROPY_SUPPORT is always supported (note 54H remains unsuported) Signed-off-by: Alberto Escolar Piedras <[email protected]>

aescolar force-pushed the cracen_rng branch from f423669 to d17dbdf Compare January 17, 2025 14:31

cvinayak approved these changes Jan 17, 2025

View reviewed changes

masz-nordic reviewed Jan 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nRF54L: Add new entropy driver based on the CRACEN HW #83972

nRF54L: Add new entropy driver based on the CRACEN HW #83972

aescolar commented Jan 14, 2025 •

edited

Loading

zephyrbot commented Jan 14, 2025 •

edited

Loading

frkv Jan 15, 2025

frkv Jan 15, 2025

cvinayak Jan 15, 2025

aescolar Jan 15, 2025

cvinayak Jan 15, 2025

cvinayak Jan 15, 2025

rettichschnidi commented Jan 16, 2025 •

edited

Loading

masz-nordic Jan 17, 2025

aescolar Jan 17, 2025

masz-nordic Jan 17, 2025

aescolar Jan 17, 2025

masz-nordic Jan 17, 2025

masz-nordic Jan 17, 2025

masz-nordic Jan 17, 2025

	Nordic nRF54L CRACEN CTR DRBG based (Random Number Generator)
	Nordic nRF54L CRACEN CTR_DRBG based (Random Number Generator)

	bool "nRF54L entropy driver based on the CRACEN CTR DRBG driver"
	bool "nRF54L entropy driver based on the CRACEN CTR_DRBG driver"

	compatible: "nordic,nrf54lcracen-ctrdrbg"
	compatible: "nordic,cracen-ctrdrbg"

nRF54L: Add new entropy driver based on the CRACEN HW #83972

Are you sure you want to change the base?

nRF54L: Add new entropy driver based on the CRACEN HW #83972

Conversation

aescolar commented Jan 14, 2025 • edited Loading

zephyrbot commented Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rettichschnidi commented Jan 16, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aescolar commented Jan 14, 2025 •

edited

Loading

zephyrbot commented Jan 14, 2025 •

edited

Loading

rettichschnidi commented Jan 16, 2025 •

edited

Loading