tests: drivers: timer: nrf_grtc: Fix test_get_ticks #83999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @adamkondraciuk |
zephyrbot
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
masz-nordic
reviewed
Jan 17, 2025
Test was occasionally failing when two types of current time reading occurred at different system tick. In that case they were of by one system tick and test was failing. Signed-off-by: Krzysztof Chruściński <[email protected]>
nordic-krch
force-pushed
the
fix_grtc_test
branch
from
078f18b to
bba72e7
Compare
Converting absolute system ticks to GRTC ticks is simple and algorithm can be simplified. Legacy algorithm was copied from nrf_rtc_timer which back then was working on 32 bits only. Signed-off-by: Krzysztof Chruściński <[email protected]>
masz-nordic
previously approved these changes
Jan 17, 2025
|
I had to add fix/optimization from #84001 because without that test was failing on cpuppr (and previously was passing because test flaw was canceled by the way |
|
fyi @adamkondraciuk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test was occasionally failing when two types of current time reading (
sys_clock_tick_get()andz_nrf_grtc_timer_read()) occurred at different system tick. In that case they were of by one system tick and test was failing.