Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tdk invensense icp101xx pressure sensor #84081

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rbuisson-invn
Copy link

drivers: sensor: icp101xx: supports icp101xx sensors
dts: supports icp101xx invn pressure sensor
module: HAL TDK module

Adds official TDK Invensense Inc. driver in TDK HAL module for icp101xx sensor.
Replacing icp10125 unofficial driver
Validated with custom setup: nrf52dk_nrf52832 + icp10125 Piromoni board

Signed-off-by: Remi Buisson [email protected]

@zephyrbot
Copy link
Collaborator

zephyrbot commented Jan 16, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_tdk zephyrproject-rtos/hal_tdk@e0ade95 zephyrproject-rtos/hal_tdk#8 zephyrproject-rtos/hal_tdk#8/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_tdk DNM This PR should not be merged (Do Not Merge) labels Jan 16, 2025
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the renaming should happen in the same commit where the old binding is removed, so the history can be bisected.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks for your review.

#include "Icp101xx.h"
#include "Icp101xxSerif.h"

#define DT_DRV_COMPAT invensense_icp101xx
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is usually placed in the main source file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks for your review.

@rbuisson-invn rbuisson-invn force-pushed the TDK_Invensense_icp101xx_pressure_sensor branch 3 times, most recently from f5b52e2 to c6b4f31 Compare January 16, 2025 15:00
icp101xx are barometric pressure and temperature sensors.
https://invensense.tdk.com/smartpressure

Signed-off-by: Remi Buisson <[email protected]>
Use official TDK Invensense driver for icp101xx sensor in tdk_hal module.

Signed-off-by: Remi Buisson <[email protected]>
Replace icp10125.
tests: sensor: rename icp10125 to icp101xx

Signed-off-by: Remi Buisson <[email protected]>
@rbuisson-invn rbuisson-invn force-pushed the TDK_Invensense_icp101xx_pressure_sensor branch from c6b4f31 to 9ed1ee8 Compare January 17, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Sensors Sensors DNM This PR should not be merged (Do Not Merge) manifest manifest-hal_tdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants