-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tdk invensense icp101xx pressure sensor #84081
base: main
Are you sure you want to change the base?
Tdk invensense icp101xx pressure sensor #84081
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the renaming should happen in the same commit where the old binding is removed, so the history can be bisected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks for your review.
#include "Icp101xx.h" | ||
#include "Icp101xxSerif.h" | ||
|
||
#define DT_DRV_COMPAT invensense_icp101xx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is usually placed in the main source file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks for your review.
f5b52e2
to
c6b4f31
Compare
icp101xx are barometric pressure and temperature sensors. https://invensense.tdk.com/smartpressure Signed-off-by: Remi Buisson <[email protected]>
Use official TDK Invensense driver for icp101xx sensor in tdk_hal module. Signed-off-by: Remi Buisson <[email protected]>
Replace icp10125. tests: sensor: rename icp10125 to icp101xx Signed-off-by: Remi Buisson <[email protected]>
c6b4f31
to
9ed1ee8
Compare
drivers: sensor: icp101xx: supports icp101xx sensors
dts: supports icp101xx invn pressure sensor
module: HAL TDK module
Adds official TDK Invensense Inc. driver in TDK HAL module for icp101xx sensor.
Replacing icp10125 unofficial driver
Validated with custom setup: nrf52dk_nrf52832 + icp10125 Piromoni board
Signed-off-by: Remi Buisson [email protected]