soc: atmel: sam: samx7x: fold atmel_samx7x_config() into early init hook

[henrikbrixandersen]

Fold atmel_samx7x_config() into soc_early_init_hook(), which is the only caller of this function.

[nandojve]

Hi @henrikbrixandersen ,

This is not part of existential part of boot process to be mixed inside soc.c.
Why do you want to do this? What we gain doing this?

[henrikbrixandersen]

This is not part of existential part of boot process to be mixed inside soc.c.

Not sure what you mean here? The code currently in soc_config.c is only called from within soc.c. This construct stems from commit 51c771e which switched the SAM E70/V71 from SYS_INIT() to soc_early_init_hook().

Why do you want to do this? What we gain doing this?

Simplification. Reduced overhead, both compile-unit-wise and function-call wise.

[nandojve]

This is not part of existential part of boot process to be mixed inside soc.c.

Not sure what you mean here? The code currently in soc_config.c is only called from within soc.c. This construct stems from commit 51c771e which switched the SAM E70/V71 from SYS_INIT() to soc_early_init_hook().

The function configure some pins but it should be part of pinctrl, not part of soc init. If you want remove the soc_config.c unit then move as a static function. Let the compiler do the job : )

[henrikbrixandersen]

The function configure some pins but it should be part of pinctrl, not part of soc init. If you want remove the soc_config.c unit then move as a static function. Let the compiler do the job : )

This is a refactoring of existing code, simply moving the function body of one function (atmel_samx7x_config()) into the only caller of that function (soc_early_init_hook()), which doesn't do much else than call the first function. Not sure where pinctrl fits into this small refactoring?

[nandojve]

The function configure some pins but it should be part of pinctrl, not part of soc init. If you want remove the soc_config.c unit then move as a static function. Let the compiler do the job : )

This is a refactoring of existing code, simply moving the function body of one function (atmel_samx7x_config()) into the only caller of that function (soc_early_init_hook()), which doesn't do much else than call the first function. Not sure where pinctrl fits into this small refactoring?

The refactor into pinctrl is not so easy. For me keeping the function is better. As far I know, the compiler will suppress the call when the function is defined as static inline.