include: util: Add memeq and bool_memcmp

[theob-pro]

Those two functions are used to compare memory area. bool_memcmp is basically memcmp but return a bool instead of an int. memeq compare the length of the memory area in addition to the bytes themselves.

[pdgendt]

I don't see the benefit of adding these, sorry.

[theob-pro]

I don't see the benefit of adding these, sorry.

No worries, it may not be useful for everyone 😀
More context on the discussion I had with @Thalley on this PR: #84018

[pdgendt]

No worries, it may not be useful for everyone 😀 More context on the discussion I had with @Thalley on this PR: #84018

What I mean was that I don't see any added value of introducing what basically is an alias...

if (memeq(buf1, size1, buf2, size2)) { /* ... */ }
/* vs */
if (size1 == size2 && memcmp(buf1, buf2, size1) == 0) { /* ... */ }

[andyross]

Tend to agree with @pdgendt, we don't want to be pushing APIs that compete with well-established controlling idioms (like the ISO C standard memcmp() in this case, but we take stuff from Linux too).

[theob-pro]

What I mean was that I don't see any added value of introducing what basically is an alias...

Maybe I am missing something but that file is full of aliases... I don't see the problem with adding new ones

Tend to agree with @pdgendt, we don't want to be pushing APIs that compete with well-established controlling idioms (like the ISO C standard memcmp() in this case, but we take stuff from Linux too).

I struggle to understand the reasoning about APIs that compete, sorry, could you develop? And those function are just more convenient to use. Nobody is forced to use them 😅

[pdgendt]

Maybe I am missing something but that file is full of aliases... I don't see the problem with adding new ones

I disagree. The file, in my opinion, provides common functions people tend to get wrong or inefficient implementations of.

I struggle to understand the reasoning about APIs that compete, sorry, could you develop? And those function are just more convenient to use. Nobody is forced to use them 😅

Nobody is forced to use them, but suddenly memeq is almost globally defined as zephyr/sys/util.h will likely be included in some way or another.

[theob-pro]

I disagree. The file, in my opinion, provides common functions people tend to get wrong or inefficient implementations of.

Sorry but I must insist, there is an alias for is_power_of_two, macro for IN_RANGE, MIN and MAX, a macro for casting a pointer to an unsigned integer. Those functions and macro are there for quality of life, for making code more readable in the end.

Nobody is forced to use them, but suddenly memeq is almost globally defined as zephyr/sys/util.h will likely be included in some way or another.

Sorry, I don't understand, what is the problem here? It will not be included in people code if they don't use it