Add few shell filters

drivers/comparator/comparator_shell.c

@@ -216,9 +216,9 @@ static int cmd_trigger_is_pending(const struct shell *sh, size_t argc, char **ar
 	return 0;
 }
 
-static bool device_is_comp_and_ready(const struct device *dev)
+static bool device_is_comp(const struct device *dev)
 {
-	return device_is_ready(dev) && DEVICE_API_IS(comparator, dev);
+	return DEVICE_API_IS(comparator, dev);
 }
 
 static void dsub_set_trigger_lookup_1(size_t idx, struct shell_static_entry *entry)
@@ -233,7 +233,7 @@ SHELL_DYNAMIC_CMD_CREATE(dsub_set_trigger_1, dsub_set_trigger_lookup_1);
 
 static void dsub_set_trigger_lookup_0(size_t idx, struct shell_static_entry *entry)
 {
-	const struct device *dev = shell_device_filter(idx, device_is_comp_and_ready);
+	const struct device *dev = shell_device_filter(idx, device_is_comp);
 
 	entry->syntax = dev != NULL ? dev->name : NULL;
 	entry->handler = NULL;
@@ -245,7 +245,7 @@ SHELL_DYNAMIC_CMD_CREATE(dsub_set_trigger_0, dsub_set_trigger_lookup_0);
 
 static void dsub_device_lookup_0(size_t idx, struct shell_static_entry *entry)
 {
-	const struct device *dev = shell_device_filter(idx, device_is_comp_and_ready);
+	const struct device *dev = shell_device_filter(idx, device_is_comp);
 
 	entry->syntax = (dev != NULL) ? dev->name : NULL;
 	entry->handler = NULL;

drivers/dac/dac_shell.c

@@ -94,14 +94,31 @@ static int cmd_write_value(const struct shell *sh, size_t argc, char **argv)
 	return 0;
 }
 
+static bool device_is_dac(const struct device *dev)
+{
+	return DEVICE_API_IS(dac, dev);
+}
+
+static void device_name_get(size_t idx, struct shell_static_entry *entry)
+{
+	const struct device *dev = shell_device_filter(idx, device_is_dac);
+
+	entry->syntax = (dev != NULL) ? dev->name : NULL;
+	entry->handler = NULL;
+	entry->help = NULL;
+	entry->subcmd = NULL;
+}
+
+SHELL_DYNAMIC_CMD_CREATE(dsub_device_name, device_name_get);
+
 SHELL_STATIC_SUBCMD_SET_CREATE(dac_cmds,
-	SHELL_CMD_ARG(setup, NULL,
+	SHELL_CMD_ARG(setup, &dsub_device_name,
 		      "Setup DAC channel\n"
 		      "Usage: setup <device> <channel> <resolution> [-b] [-i]\n"
 		      "-b Enable output buffer\n"
 		      "-i Connect internally",
 		      cmd_setup, 4, 2),
-	SHELL_CMD_ARG(write_value, NULL,
+	SHELL_CMD_ARG(write_value, &dsub_device_name,
 		      "Write DAC value\n"
 		      "Usage: write <device> <channel> <value>",
 		      cmd_write_value, 4, 0),

drivers/i2c/i2c_shell.c

@@ -336,9 +336,14 @@ static int cmd_i2c_speed(const struct shell *shell_ctx, size_t argc, char **argv
 	return 0;
 }
 
+static bool device_is_i2c(const struct device *dev)
+{
+	return DEVICE_API_IS(i2c, dev);
+}
+
 static void device_name_get(size_t idx, struct shell_static_entry *entry)
 {
-	const struct device *dev = shell_device_lookup(idx, NULL);
+	const struct device *dev = shell_device_filter(idx, device_is_i2c);
 
 	entry->syntax = (dev != NULL) ? dev->name : NULL;
 	entry->handler = NULL;

drivers/led/led_shell.c

@@ -330,14 +330,14 @@ cmd_write_channels(const struct shell *sh, size_t argc, char **argv)
 	return err;
 }
 
-static bool device_is_led_and_ready(const struct device *dev)
+static bool device_is_led(const struct device *dev)
 {
-	return device_is_ready(dev) && DEVICE_API_IS(led, dev);
+	return DEVICE_API_IS(led, dev);
 }
 
 static void device_name_get(size_t idx, struct shell_static_entry *entry)
 {
-	const struct device *dev = shell_device_filter(idx, device_is_led_and_ready);
+	const struct device *dev = shell_device_filter(idx, device_is_led);
 
 	entry->syntax = (dev != NULL) ? dev->name : NULL;
 	entry->handler = NULL;

drivers/pwm/pwm_shell.c

@@ -126,14 +126,14 @@ static int cmd_nsec(const struct shell *sh, size_t argc, char **argv)
 	return 0;
 }
 
-static bool device_is_pwm_and_ready(const struct device *dev)
+static bool device_is_pwm(const struct device *dev)
 {
-	return device_is_ready(dev) && DEVICE_API_IS(pwm, dev);
+	return DEVICE_API_IS(pwm, dev);
 }
 
 static void device_name_get(size_t idx, struct shell_static_entry *entry)
 {
-	const struct device *dev = shell_device_filter(idx, device_is_pwm_and_ready);
+	const struct device *dev = shell_device_filter(idx, device_is_pwm);
 
 	entry->syntax = (dev != NULL) ? dev->name : NULL;
 	entry->handler = NULL;

drivers/regulator/regulator_shell.c

@@ -522,9 +522,14 @@ static int cmd_shipmode(const struct shell *sh, size_t argc, char **argv)
 	return 0;
 }
 
+static bool device_is_regulator(const struct device *dev)
+{
+	return DEVICE_API_IS(regulator, dev);
+}
+
 static void device_name_get(size_t idx, struct shell_static_entry *entry)
 {
-	const struct device *dev = shell_device_lookup(idx, NULL);
+	const struct device *dev = shell_device_filter(idx, device_is_regulator);
 
 	entry->syntax = (dev != NULL) ? dev->name : NULL;
 	entry->handler = NULL;

drivers/stepper/stepper_shell.c

@@ -69,7 +69,7 @@ static void print_callback(const struct device *dev, const enum stepper_event ev
 
 static bool stepper_device_check(const struct device *dev)
 {
-	return DEVICE_API_IS(stepper, dev) && device_is_ready(dev);
+	return DEVICE_API_IS(stepper, dev);
 }
 
 static const struct stepper_direction_map stepper_direction_map[] = {