Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vague block focus in email composer #2283

Open
sefsh opened this issue Oct 22, 2024 · 1 comment
Open

Vague block focus in email composer #2283

sefsh opened this issue Oct 22, 2024 · 1 comment
Labels
🐜 bug Something isn't working 🛑 potentially blocked Potentially blocked by prerequisites (double check or ask someone, as it may have changed)

Comments

@sefsh
Copy link

sefsh commented Oct 22, 2024

Description

Steps to reproduce

  1. Create an email activity
  2. Start adding blocks in the composer
  3. Add a block
  4. Click on the image Tune button

Expected Behaviour

Clear highlighting of what is being "tuned".

image

Something like this.

background: #e1f2ff;
  border: 1px solid #9ed5ff;
  border-radius: 5px;

Actual Behaviour

image
Vague highlighting of what is being "tuned".

@sefsh sefsh added the 🐜 bug Something isn't working label Oct 22, 2024
@ajoensson ajoensson self-assigned this Jan 19, 2025
@ajoensson ajoensson removed their assignment Jan 19, 2025
@richardolsson
Copy link
Member

This issue should be revisited with the new editor being introduced in #2476, and when that happens it's a good idea to look at @ajoensson's fix in #2481 which contains styling that can be reused in the new code.

@richardolsson richardolsson added the 🛑 potentially blocked Potentially blocked by prerequisites (double check or ask someone, as it may have changed) label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐜 bug Something isn't working 🛑 potentially blocked Potentially blocked by prerequisites (double check or ask someone, as it may have changed)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants