fix: make it more clear what email block is focused in the composer #2481
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Omg this is great work, and now I feel bad, because I had missed this issue and I should have closed it. We are currently working on an entirely new composer (#2476) so although the issue is still somewhat relevant (as a way of tracking requirements) this fix is going into an editor that will be removed very soon. 😞 |
|
Gotcha gotcha! No worries! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the email composer by more clearly highlighting the selected/focused block that is being tuned with the tune-button.
Screenshots
Before:
After:
Changes
Adds a border to the focused block, making the highlight more distinct. The colors and size are based on the description in #2283, the main difference is using
borderRadius: 1, which results in a 4px radius rather than the suggested 5px.Notes to reviewer
Should be possible to test in any email composer.
Related issues
Resolves #2283