Issue 2084/activity list items layout - adding subtitles #2213
Conversation
There was a problem hiding this comment.
Nice work @neta-kedem!
I'll take a closer look at the code, but the first thing I noticed when I tried the preview build is that the stats have moved out of alignment.
This is what an activity list looks like on main (running on app.dev.zetkin.org):
Below is what it looks like in the preview build for this branch. Note how the little numeric chips are no longer aligned along the same vertical line.
Can you take a look at this before a more thorough review of the code?
|
Hi @neta-kedem ! I see that you made an update to the pr a while back, sorry for the slow response from us! When i look at the deployed version the alignment is still wonky like Richard commented. Do you wanna look into it again? |
|
Yes, I'll look back into it tomorrow at the hackathon |
# Conflicts: # src/features/campaigns/components/ActivityList/items/CanvassAssignmentListItem.tsx
There was a problem hiding this comment.
Woop woop looking good! Looking at the build it looks very neat and i like getting the information about the deadlines/start dates in the activity overview like this!
However, we do have an issue - it's not realted to code that you have written, directly, but it's the ZUIRelativeTime component that is not behaving very well when it comes to indicating things happening "tomorrow":
As you can see, the ZUIRelativeTime says that this task has its deadline "tomorrow" - which is not true, it has a deadline on December 12 and the day I am viewing this is December 10. We have recently have had another volunteer attempt to attack this problem, without a concrete solution. I'm gonna loop in @richardolsson here to see what his thoughts are.
My opinion is that it's problematic to have a component give misleading information like this, but I also feel like it's a bit of a can of worms to try to solve the underlying issue...
So this is why I'm marking this as "changes requested" for the moment, even though I cannot at this exact moment say what specific changes should be made to make this a more truthful component....
| @@ -65,19 +67,21 @@ export enum STATUS_COLORS { | |||
| RED = 'red', | |||
| } | |||
|
|
|||
| export type AcitivityListItemProps = { | |||
There was a problem hiding this comment.
🏅 ⭐ for finding one of these miss-spellings!!
Description
This PR adds subtitles to activity list items, and makes minor UI changes to show it
Screenshots
Changes
Notes to reviewer
not fully polished, but it's working so I'm pushing for the demo
Related issues
Resolves #2084