Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MonthCalendarEvent-Rendering around DST #2458

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix MonthCalendarEvent-Rendering around DST #2458

wants to merge 2 commits into from

Conversation

xela1601
Copy link
Collaborator

@xela1601 xela1601 commented Jan 6, 2025 •
edited
Loading

Description

This PR fixes the duplicated events in the CalendarMonthView in case of events near a DST-shift.

Details

There were two bugs which needed to be fixed here.
Both bugs caused the event to show up twice as much resulting in 2 * 2 = 4 events being shown in the end.

  1. the first one being fixed in 69313af caused the events as being loaded by useEventsFromDateRange-hook to occur 2 times within the returned EventActivity[]-array.
  2. the second one being fixed in 4cff80a caused each event to occur twice with different dates (30th and 31st of March in the case of the test event Test Event Issue 2442) within the returned UseMonthCalendarEventsReturn-object of useMonthCalendarEvents-hook

Screenshots

CleanShot 2025-01-06 at 17 34 17

Changes

  • fixes duplicated events in the CalendarMonthView in case event is near a DST-shift

Notes to reviewer

Related issues

Resolves #2442

@xela1601
fixed creation of duplicated events in case of DST-shift
69313af 
within `useEventsFromDateRange`-hook

Signed-off-by: Alexander Schreiner <[email protected]>
@xela1601
fixed creation of duplicated event on next day in AnyClusteredEvent…
4cff80a 
… objects in case of DST-shift

within `useMonthCalendarEvents`-hook

Signed-off-by: Alexander Schreiner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Month calendar renders events weirdly around DST
1 participant
@xela1601