-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish metrics page and flow #2461
Open
rebecarubio
wants to merge
23
commits into
main
Choose a base branch
from
undocumented/polish-metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in output page, fix styles
…essary imports, remove alert component
I can't find the new UI. Was the tab lost in the merge? |
The tab is not lost but the file is called "logging" so I didn't want to do the full renaming of the tab before talking with a native speaker (as we discuss in K&K), so now in the branch we see the "report" file that is the old one. |
rebecarubio
changed the title
Polish metrics page and flow
WIP Polish metrics page and flow
Jan 15, 2025
rebecarubio
changed the title
WIP Polish metrics page and flow
Polish metrics page and flow
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a new design for "outcomes" page, now renamed as "report" page. It polishes the creation, listing, deletion and edition of metrics for the canvas assignment.
Screenshots
Changes
Outcomes
tab forReport
Choise Metrics
fromScale Metrics
Edit
andDelete
buttons for iconsCheckbox
in edit modeModal
to open in edit modeModal
before deleting a metricNotes to reviewer
None
Related issues
None