Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish metrics page and flow #2461

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Conversation

rebecarubio
Copy link
Contributor

@rebecarubio rebecarubio commented Jan 9, 2025

Description

This PR implements a new design for "outcomes" page, now renamed as "report" page. It polishes the creation, listing, deletion and edition of metrics for the canvas assignment.

Screenshots

image

Changes

  • Renames Outcomes tab for Report
  • Implements new design to choose the "Reporting level" now called "Data collection"
  • Adds new icons to differentiate Choise Metrics from Scale Metrics
  • Places the questions toolbar on the bottom of the page
  • Changes Edit and Delete buttons for icons
  • Removes Checkbox in edit mode
  • Adds a Modal to open in edit mode
  • Adds a confirmation Modal before deleting a metric

Notes to reviewer

None

Related issues

None

@richardolsson
Copy link
Member

@rebecarubio
Copy link
Contributor Author

I can't find the new UI. Was the tab lost in the merge?

https://app-zetkin-wi1wgb361-zetkin.vercel.app/organize/1/projects/9/areaassignments/6762b039174d1f80e2824b1a

The tab is not lost but the file is called "logging" so I didn't want to do the full renaming of the tab before talking with a native speaker (as we discuss in K&K), so now in the branch we see the "report" file that is the old one.

@rebecarubio rebecarubio changed the title Polish metrics page and flow WIP Polish metrics page and flow Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants