Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2345 - Redirects user if deleting person from current Org #2484

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

MattettaM
Copy link
Collaborator

User gets redirected to the Peoples page if deleting a person from the organization that is currently active

Description

This PR adds redirect for the user back to the Peoples page when the user removes a sub org from a person, if that is the current org

Changes

  • Adds a redirect when deleting a sub org from a person if the sub org is the active org

Notes to reviewer

  1. Go to a person in an organization, via for example a list.
  2. Delete the person from the organization at the bottom of the page.
  3. You should be redirected to the Peoples page if the deleted organization matches the active organization

Related issues

Resolves #2345

User gets redirected to the Peoples page if deleting a person from the organization that is currently active
Copy link
Member

@richardolsson richardolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple solution that solves a gnarly problem – what could possibly be better than that? Nice work! 🎉

I have reviewed the code and I have tried the preview build and it all looks good to me. 💯

@richardolsson richardolsson merged commit d58fee8 into main Jan 19, 2025
6 checks passed
@richardolsson richardolsson deleted the issue2345-redirectOnRemoveSubOrgFromPerson branch January 19, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI is not updated when organization membership of current organization is removed from person
2 participants