VerifyBlocking PR #1001
Open
VerifyBlocking PR #1001
+52
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,16 @@ | |||
| package zingg.common.client.util; | |||
|
|
|||
| public class PathUtil { | |||
Check warning
Code scanning / PMD
This utility class has a non-private constructor Warning
sonalgoyal
requested changes
Jan 15, 2025
|
|
||
| public class PathUtil { | ||
|
|
||
| public static String getSparkLocationFromPath(String name){ |
There was a problem hiding this comment.
since these are spark and snow specific, it is better to move these methods to SnowPipe and SparkPipe. call them massageLocation/massageTableName. define method setLocation in spark and call the massageLocation in it. Use setLocation whever we are calling SparkPipe.setLocation. Similarly for Snow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.