Provide a Scope per server call (#3197)
#3276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
987Nabil
force-pushed
the
sope-per-request
branch
from
e7140d6 to
631581e
Compare
jgranstrom
reviewed
Jan 18, 2025
Comment on lines
+95
to
+96
| val scope = Scope.unsafe.make | ||
| writeResponse(ctx, runtime, scope.use(exit), req)(releaseRequest) |
There was a problem hiding this comment.
Can this not close the scope before the response is written? So, for example, if a resource in the Scope is a scoped stream, it can close before being fully written to the response by being closed here when the handler finishes, and not when actually writing it is done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3197
/claim #3197