-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix J-Stage translator to handle Japanese names properly. #3157
Conversation
I have a generic question about the purpose of These are not called "family name" "given name" or so, IMO for good reason, because what comes first in a name may or may not be the "given name", and concepts like "family/given name" may or may not apply in a particular socio-linguistic context. Can we say that for the name I don't feel there are clear-cut answers as far as translator codes are concerned - while we strive for accuracy by default, we acknowledge that manual processing by the user is often necessary. Ultimately, it's how the user uses the bib items that matter, and I would like to know more about the impacts of different choices for this problem. So in this particular case (Japanese persons' names in Japanese), what should be the best default choice and why? (I'd also like to hear @adam3smith's view; thanks) |
I think the goal should be to provide optimal output with Zotero's native format (i.e. CSL via citeproc-js). The standard recommendation, e.g. by W3C, is to use family and given/other when splitting names is necessary (as it is for citation generation), so Zotero's field naming isn't ideal here. I'm not sure if renaming these in the UI is up for grabs or if there are concerns about confusing users. |
@zoe-translates This is because: It seems many(all?) parts of Zotero regard Practically, storing our family name into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @aldente-hu for the clarifications.
I tested generating citations bibliographies with Japanese author-names, using the items created by this translator with your changes. I don't see any problem with the generated output; the names are correctly spelled out.
Co-authored-by: zoe-translates <[email protected]>
Thanks @zoe-translates . Your suggestion looks so good! I've committed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I learn a lot from contributors like you. BTW, if you see other problems like this with Japanese in item metadata, please feel free to report or submit a PR.
Thanks as well! I'll touch another one (such as CiNii translator). |
What makes this PR remain unmerged? |
Nothing! Thanks for your great work. |
Hi! I have been struggling with a similar problem (family name and given name getting swapped) when importing items from CiNii. Is it possible for you to fix this problem with CiNii as well? |
@jajagara |
Oh! That's what it is! Thank you SOOO much!! とても助かります!! |
It's my treasure! |
J-Stage translator handles Japanese names improperly, treating their first name as their last name and vise versa.
This problem is caused by the BibTex records of J-Stage. So I've fixed it to look at the RIS records instead.