Do not set arXiv DOI #3384
Closed
Do not set arXiv DOI #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to Zotero 7, was able to include multiple tests
Followed most of the review points, left `async` for now until there's more opinions on this. Will update again when remaining points have been clarified
Better handles the case where the ISBN search failed and relying on Kluwer itself as a fallback.
Refactored search logic and arbitration blog logic (supports multiples blog articles as well). All items set their URL now. Snapshots were considered but rejected since they only offer marginal improvements at a considerably larger size (footnote callout number are not clickable, only improvement is that in the endnotes the numbers are clickable).
… cases - Saving dates in ISO format - When `date` was set for cases or statutes published in a publication, `dateDecided` and `dateEnacted` respectively were ignored
|
Revert Kluwer changes in this branch, but otherwise... @adam3smith, do we want arXiv DOIs? I really have no idea. |
|
Oops sorry, my branches got mixed up... I'll probably end up deleting and re-doing #3161 |
|
I don't understand why we wouldn't want the DOI for arXiv? That's why they started issuing them, just like all.other preprint servers. |
|
OK, sorry @thebluepotato, appreciate this fix but I think we're going to do the opposite. |
|
(I see the argument for not saving redundant IDs, but choosing which IDs are relevant is ultimately the citation processor / style's job, and we should err on the side of saving as much as possible.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the recent changes to the arXiv translator, items imported via identifier or from arXiv search pages no longer include the arXiv issued DOI, as intended. However, when imported from the webpage, the DOI would still be set.
I believe the consensus is that the DOI should reflect the published version. We have easy access to the arXiv page anyway.