Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up, delint, performance #38

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

joelpittet
Copy link

This may look unwieldy but it's not terribly exhaustive clean-up.

  • Delinted most of the JavaScript.
  • Wrapped the JS in a closure for better no-conflict support.
  • Made all tabs spacing into 2 spaces for consistency.
  • Removed a few overqualified CSS selectors (May be better to BEMize these to avoid conflicts)
  • Commented out the CSS generic table styles, probably should move that to a different CSS for the demo presentation only?
  • Moved the events to the bottom of the JS.
  • Made the function declarations use all the same declaration style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant