Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up FCP (first contentful paint) #4329

Merged
merged 7 commits into from
Mar 28, 2024
Merged

Conversation

nboisteault
Copy link
Member

@nboisteault nboisteault commented Mar 26, 2024

Speed up FCP (first contentful paint). This PR allows JavaScript scripts to be loaded after the HTML is loaded and parsed thanks to defer attribute. It is interesting for users with a slow connection, this way they will not wait too long with a blank page.

Funded by 3Liz

TODO:

@github-actions github-actions bot added this to the 3.8.0 milestone Mar 26, 2024
@nboisteault nboisteault added refactoring performance run end2end If the PR must run end2end tests or not labels Mar 26, 2024
@nboisteault nboisteault marked this pull request as ready for review March 26, 2024 15:15
@rldhont
Copy link
Collaborator

rldhont commented Mar 26, 2024

@nboisteault can you add some description to this PR to explain how your speed up lizmap loading ?

Copy link
Collaborator

@rldhont rldhont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Describe changes

@nboisteault nboisteault changed the title Speed up Lizmap loading Speed up FCP (first contentful paint) Mar 26, 2024
@nboisteault
Copy link
Member Author

Describe changes

Done.

Copy link
Collaborator

@rldhont rldhont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nboisteault nboisteault merged commit 8a9eb40 into 3liz:master Mar 28, 2024
12 checks passed
@nboisteault nboisteault deleted the fast-lizmap branch March 28, 2024 09:56
rldhont added a commit to rldhont/lizmap-web-client that referenced this pull request May 3, 2024
The popup dock is build client side by the JS and depends on `lizDict`.
Since 3liz#4329 the popup dock could be created before the `lizDict` is available.
rldhont added a commit to rldhont/lizmap-web-client that referenced this pull request May 7, 2024
The popup dock is build client side by the JS and depends on `lizDict`.
Since 3liz#4329 the popup dock could be created before the `lizDict` is available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance refactoring run end2end If the PR must run end2end tests or not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants