-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up FCP (first contentful paint) #4329
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nboisteault
force-pushed
the
fast-lizmap
branch
from
March 26, 2024 09:56
7f5af90
to
b0c946c
Compare
nboisteault
force-pushed
the
fast-lizmap
branch
from
March 26, 2024 10:33
b0c946c
to
154965f
Compare
nboisteault
added
refactoring
performance
run end2end
If the PR must run end2end tests or not
labels
Mar 26, 2024
nboisteault
force-pushed
the
fast-lizmap
branch
from
March 26, 2024 15:18
09ba953
to
9fc070d
Compare
@nboisteault can you add some description to this PR to explain how your speed up lizmap loading ? |
rldhont
requested changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Describe changes
nboisteault
changed the title
Speed up Lizmap loading
Speed up FCP (first contentful paint)
Mar 26, 2024
Done. |
rldhont
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
laurentj
approved these changes
Mar 27, 2024
rldhont
added a commit
to rldhont/lizmap-web-client
that referenced
this pull request
May 3, 2024
The popup dock is build client side by the JS and depends on `lizDict`. Since 3liz#4329 the popup dock could be created before the `lizDict` is available.
rldhont
added a commit
to rldhont/lizmap-web-client
that referenced
this pull request
May 7, 2024
The popup dock is build client side by the JS and depends on `lizDict`. Since 3liz#4329 the popup dock could be created before the `lizDict` is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up FCP (first contentful paint). This PR allows JavaScript scripts to be loaded after the HTML is loaded and parsed thanks to
defer
attribute. It is interesting for users with a slow connection, this way they will not wait too long with a blank page.Funded by 3Liz
TODO: