New option to disable the automatic permalink

[rldhont]

In the main section of the JSON, add a new option to enable the automatic permalink : automatic_permalink.

It will be enabled by default.

Linked to 3liz/lizmap-plugin#590

[Gustry]

It will be enabled by default.

You mean "automatic permalink" will be enabled by default ? So it will be the reverse compared to the plugin ?

[rldhont]

It will be enabled by default.

You mean "automatic permalink" will be enabled by default ? So it will be the reverse compared to the plugin ?

I keep the LWC 3.7 fonctionnality

[nboisteault]

It will be enabled by default.

You mean "automatic permalink" will be enabled by default ? So it will be the reverse compared to the plugin ?

I keep the LWC 3.7 fonctionnality

It could be disabled by default in LWC 3.8.

[rldhont]

It will be enabled by default.

You mean "automatic permalink" will be enabled by default ? So it will be the reverse compared to the plugin ?

I keep the LWC 3.7 fonctionnality

It could be disabled by default in LWC 3.8.

I will do an other PR in this case after validation and backport.

[Gustry]

I keep the LWC 3.7 fonctionnality

We need to be consistent with the plugin so :) Which is not the case, or to define what happen if the key is not found.
So you consider if the key is not found or True, then the automatic permalink is done, right ?

It could be disabled by default in LWC 3.8.

Well, if we want to change the default behavior, I think it's better to do it ASAP.

People are creating new projects. The more we wait, the more they will have to manually update their CFG file.

[3liz-bot]

The backport to release_3_7 failed:

The process '/usr/bin/git' failed with exit code 1

stderr

error: could not apply ba73e8cf1... New option to disable the automatic permalink
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

stdout

Auto-merging assets/src/modules/Permalink.js
Auto-merging assets/src/modules/config/Options.js
CONFLICT (content): Merge conflict in assets/src/modules/config/Options.js

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_7 release_3_7
# Navigate to the new working tree
cd .worktrees/backport-release_3_7
# Create a new branch
git switch --create backport-4586-to-release_3_7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ba73e8cf18ac06999b20c275904553ec48e694f6
# Push it to GitHub
git push --set-upstream origin backport-4586-to-release_3_7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_7

Then, create a pull request where the base branch is release_3_7 and the compare/head branch is backport-4586-to-release_3_7.