raina cambpell PR #85
Conversation
| Z: 1, | ||
| }; | ||
|
|
||
| let lettersArr = Object.keys(letterPool); |
There was a problem hiding this comment.
Remember we want to reserve the use of let for variables to look to re-assign later on and const for variables that we want to protect from re-assignment.
| export const drawLetters = () => { | ||
| // Implement this method for wave 1 | ||
| let hand = []; | ||
| let letterPoolCopy = [...lettersPool]; |
There was a problem hiding this comment.
I see you made a copy of lettersPool but it doesn't seemed like it was mutated anywhere. So my question is, do you think we could have just used lettersPool in place of letterPoolCopy?
There was a problem hiding this comment.
Actually, disregard this comment! Upon further inspection I can see where you mutated it!
| let input_letter_count = {}; | ||
| for (let i = 0; i < input.length; i++) { | ||
| let letter = input[i]; | ||
| input_letter_count[letter] = (input_letter_count[letter] || 0) + 1; |
| score += 8; | ||
| } | ||
|
|
||
| return score; |
| let highestScore = 0; | ||
| let winningWord = ''; |
There was a problem hiding this comment.
If we know we want to return these variables in object form, could just initialize said object here?
| } | ||
| } | ||
|
|
||
| return { word: winningWord, score: highestScore }; |
There was a problem hiding this comment.
Nice job, Raina! As you probably noticed, I didn't give too much feedback due to the scope of the project (Translating your python code to Javascript code). I tried to just point out any glaring issues, if any. With that being said, if you want to discuss anything in greater detail, feel free to reach out to me!
No description provided.