Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raina cambpell PR #85

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "node",
"request": "launch",
"name": "Launch Program",
"skipFiles": [
"<node_internals>/**"
],
"program": "${workspaceFolder}/src/adagrams.js"
}
]
}
146 changes: 142 additions & 4 deletions src/adagrams.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,153 @@
const letterPool = {
A: 9,
B: 2,
C: 2,
D: 4,
E: 12,
F: 2,
G: 3,
H: 2,
I: 9,
J: 1,
K: 1,
L: 4,
M: 2,
N: 6,
O: 8,
P: 2,
Q: 1,
R: 6,
S: 4,
T: 6,
U: 4,
V: 2,
W: 2,
X: 1,
Y: 2,
Z: 1,
};

let lettersArr = Object.keys(letterPool);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember we want to reserve the use of let for variables to look to re-assign later on and const for variables that we want to protect from re-assignment.

let lettersPool = [];
lettersArr.forEach((letter) => {
console.log(letter);
for (let i = 0; i < letterPool[letter]; i++) {
lettersPool.push(letter);
}
});
console.log(lettersPool);

export const drawLetters = () => {
// Implement this method for wave 1
let hand = [];
let letterPoolCopy = [...lettersPool];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you made a copy of lettersPool but it doesn't seemed like it was mutated anywhere. So my question is, do you think we could have just used lettersPool in place of letterPoolCopy?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, disregard this comment! Upon further inspection I can see where you mutated it!

for (let i = 0; i < 10; i++) {
let randomIndex = Math.floor(
Math.random() * Object.keys(letterPool).length
);
// Create a random letter from the list of letters
// using the random index
let selectedLetter = letterPoolCopy[randomIndex];
hand.push(selectedLetter);
letterPoolCopy.splice(randomIndex, 1);
}
return hand;
};

export const usesAvailableLetters = (input, lettersInHand) => {
// Implement this method for wave 2
// create variable to count occurrences of each letter in word
input = input.toUpperCase();
let input_letter_count = {};
for (let i = 0; i < input.length; i++) {
let letter = input[i];
input_letter_count[letter] = (input_letter_count[letter] || 0) + 1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, I'm stealing this! 😭

}

// create variable to count occurrences of each letter in the letter bank
let bank_letter_count = {};
for (let i = 0; i < lettersInHand.length; i++) {
let letter = lettersInHand[i];
bank_letter_count[letter] = (bank_letter_count[letter] || 0) + 1;
}

// compare the input_letter_count and bank_letter_count to see if input can be made
for (let letter in input_letter_count) {
let count = input_letter_count[letter];
// check if not in bank_letter_count
if (!(letter in bank_letter_count) || count > bank_letter_count[letter]) {
return false;
}
}

return true;
};

export const scoreWord = (word) => {
// Implement this method for wave 3
let letter_values = {
A: 1,
B: 3,
C: 3,
D: 2,
E: 1,
F: 4,
G: 2,
H: 4,
I: 1,
J: 8,
K: 5,
L: 1,
M: 3,
N: 1,
O: 1,
P: 3,
Q: 10,
R: 1,
S: 1,
T: 1,
U: 1,
V: 4,
W: 4,
X: 8,
Y: 4,
Z: 10,
};

let score = 0;
word = word.toUpperCase();

for (let i = 0; i < word.length; i++) {
let letter = word[i];
score += letter_values[letter] || 0;
}

if (word.length >= 7 && word.length <= 10) {
score += 8;
}

return score;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️

};

export const highestScoreFrom = (words) => {
// Implement this method for wave 4
let highestScore = 0;
let winningWord = '';
Comment on lines +130 to +131

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we know we want to return these variables in object form, could just initialize said object here?


// check through each
// console.log(108, words);
for (let i = 0; i < words.length; i++) {
const word = words[i];
const score = scoreWord(word);

if (score > highestScore) {
highestScore = score;
winningWord = word;
} else if (score === highestScore) {
if (
winningWord.length !== 10 &&
(word.length === 10 || word.length < winningWord.length)
) {
winningWord = word;
}
}
}

return { word: winningWord, score: highestScore };

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very easy to follow!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, Raina! As you probably noticed, I didn't give too much feedback due to the scope of the project (Translating your python code to Javascript code). I tried to just point out any glaring issues, if any. With that being said, if you want to discuss anything in greater detail, feel free to reach out to me!

};
8 changes: 5 additions & 3 deletions test/adagrams.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ describe("Adagrams", () => {
});

it("returns a score of 0 if given an empty input", () => {
throw "Complete test";
expectScores({
'':0,
})
});

it("adds an extra 8 points if word is 7 or more characters long", () => {
Expand All @@ -133,7 +135,7 @@ describe("Adagrams", () => {
});
});

describe.skip("highestScoreFrom", () => {
describe("highestScoreFrom", () => {
it("returns a hash that contains the word and score of best word in an array", () => {
const words = ["X", "XX", "XXX", "XXXX"];
const correct = { word: "XXXX", score: scoreWord("XXXX") };
Expand All @@ -145,7 +147,7 @@ describe("Adagrams", () => {
const words = ["XXX", "XXXX", "X", "XX"];
const correct = { word: "XXXX", score: scoreWord("XXXX") };

throw "Complete test by adding an assertion";
expect(highestScoreFrom(words)).toEqual(correct);
});

describe("in case of tied score", () => {
Expand Down