Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PackageManifest utilities for working with Compilers list [APE-1497] #94

Merged
merged 12 commits into from
Nov 4, 2023
Merged

feat: PackageManifest utilities for working with Compilers list [APE-1497] #94

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fb3db29
feat: compilers util
antazoey Nov 2, 2023
5908929
fix: handle None contract types
antazoey Nov 2, 2023
3b87cbc
test: improv test
antazoey Nov 2, 2023
8ed2535
test: improv test
antazoey Nov 2, 2023
89946a8
docs: add method doc
antazoey Nov 2, 2023
16848d7
chore: rm mistake
antazoey Nov 2, 2023
17cd787
docs: revise
antazoey Nov 2, 2023
67c6aed
fix: oops
antazoey Nov 2, 2023
912685a
chore: pr feedback
antazoey Nov 4, 2023
614b34b
test: test
antazoey Nov 4, 2023
4f84ed6
fix: types
antazoey Nov 4, 2023
c8e85ad
chore: simpler
antazoey Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions ethpm_types/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,9 +291,6 @@ def add_compilers(self, *compilers: Compiler):
compilers.
"""

full_list: List[Compiler] = self.compilers or []
for compiler in compilers:
if compiler not in full_list:
full_list.append(compiler)

self.compilers = full_list
start = self.compilers or []
start.extend([c for c in compilers if c not in start])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the future I think .extend takes in a sequence so you can just do .extend(c for c in ...)

self.compilers = start