feat: PackageManifest utilities for working with Compilers list [APE-1497] #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
feat/compiler-tools
branch
from
210eabd to
aaddee5
Compare
antazoey
force-pushed
the
feat/compiler-tools
branch
from
aaddee5 to
fb3db29
Compare
antazoey
force-pushed
the
feat/compiler-tools
branch
from
b6a3b77 to
5908929
Compare
antazoey
force-pushed
the
feat/compiler-tools
branch
from
915cfce to
3b87cbc
Compare
antazoey
changed the title
3 tasks
|
@fubuloubu thoughts? The changes here are rather agnostic. |
antazoey
commented
Nov 3, 2023
ethpm_types/manifest.py
Outdated
|
|
||
| return None | ||
|
|
||
| def update_compilers(self, compilers: List[Compiler]): |
There was a problem hiding this comment.
could also be extend_compilers ?
There was a problem hiding this comment.
and could be add_compilers(*compilers: Sequence[Compiler])
fubuloubu
previously approved these changes
Nov 3, 2023
fubuloubu
reviewed
Nov 4, 2023
|
|
||
| self.compilers = full_list | ||
| start = self.compilers or [] | ||
| start.extend([c for c in compilers if c not in start]) |
There was a problem hiding this comment.
for the future I think .extend takes in a sequence so you can just do .extend(c for c in ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Checklist