-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: make a documentation page outlining the terminology based on the spreadsheet #572
docs: make a documentation page outlining the terminology based on the spreadsheet #572
Conversation
docs/terminology.md
Outdated
| Variables | A State field that holds experimental variables, which are defined according to name, type, units, allowed values, and range. | Experimentalists, Experiment Runners, Theorists | | ||
| VariableCollection | Immutable metadata about dependent variables, independent variables, and covariates. | Experimentalists, Experiment Runners, Theorists | | ||
| Conditions | A State field that defines what observations should be collected according to a specific combination of values of the independent variables | Experimentalists, Experiment Runners, Theorists | | ||
| Experiment Data | A State field that holds observations which correspond to the specified conditions. | Experiment Runners, Theorists | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Experiment Data field also holds the conditions.
docs/terminology.md
Outdated
| Conditions | A State field that defines what observations should be collected according to a specific combination of values of the independent variables | Experimentalists, Experiment Runners, Theorists | | ||
| Experiment Data | A State field that holds observations which correspond to the specified conditions. | Experiment Runners, Theorists | | ||
| Model | A State field that holds the the collection of best fit equations produced by theorists. | Theorists, Experimentalists | | ||
| Components | The distinct yet flexible capabilities of the AutoRA framework. | Experimentalists, Experiment Runners, Theorists | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't very descriptive. Might want to change to something like "the objects that can act on the state - e.g., experimentalists, experiment runners, theorists."?
docs/terminology.md
Outdated
| Experiment Data | A State field that holds observations which correspond to the specified conditions. | Experiment Runners, Theorists | | ||
| Model | A State field that holds the the collection of best fit equations produced by theorists. | Theorists, Experimentalists | | ||
| Components | The distinct yet flexible capabilities of the AutoRA framework. | Experimentalists, Experiment Runners, Theorists | | ||
| Experimentalist | A module that takes in models and outputs new conditions, which are intended to yield novel observations. | Experimentalists | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the word module here and in the next two, but with Components explicitly defined, should we use that terminology instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, not all experimentalists take in models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should maybe update the core diagram that we use throughout the user guide then: https://autoresearch.github.io/autora/img/experimentalist.png
docs/terminology.md
Outdated
| Model | A State field that holds the the collection of best fit equations produced by theorists. | Theorists, Experimentalists | | ||
| Components | The distinct yet flexible capabilities of the AutoRA framework. | Experimentalists, Experiment Runners, Theorists | | ||
| Experimentalist | A module that takes in models and outputs new conditions, which are intended to yield novel observations. | Experimentalists | | ||
| Theorist | A module that takes in the full collection of conditions and observations and outputs equations that link the two (i.e., models) | Theorists | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say outputs models instead of equations because they don't always have to output an equation (although all of ours currently do).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! I have some comments, but nothing major. Feel free to ignore the comments if you don't agree!
…-terminology-based-on-the-spreadsheet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Still one comment, but just a thought, not a necessary change.
Hi @benwandrew, thanks for this! I'd love to look at this PR, but I won't get to it until next week. Can you keep it open until then? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @benwandrew , thanks for hanging fire on this one. This is extremely valuable!
I've got a couple of questions and suggestions.
Co-authored-by: John Gerrard Holland <[email protected]>
Co-authored-by: John Gerrard Holland <[email protected]>
Co-authored-by: John Gerrard Holland <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Description
Adds a page for essential terminology in AutoRA.
resolves #516
Type of change
Remarks (Optional)