Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make a documentation page outlining the terminology based on the spreadsheet #572

Conversation

benwandrew
Copy link
Collaborator

Description

Adds a page for essential terminology in AutoRA.

resolves #516

Type of change

  • docs: Documentation only changes

Remarks (Optional)

  • i took a crack, but please help with concise descriptions for each term!

docs/terminology.md Outdated Show resolved Hide resolved
| Variables | A State field that holds experimental variables, which are defined according to name, type, units, allowed values, and range. | Experimentalists, Experiment Runners, Theorists |
| VariableCollection | Immutable metadata about dependent variables, independent variables, and covariates. | Experimentalists, Experiment Runners, Theorists |
| Conditions | A State field that defines what observations should be collected according to a specific combination of values of the independent variables | Experimentalists, Experiment Runners, Theorists |
| Experiment Data | A State field that holds observations which correspond to the specified conditions. | Experiment Runners, Theorists |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Experiment Data field also holds the conditions.

| Conditions | A State field that defines what observations should be collected according to a specific combination of values of the independent variables | Experimentalists, Experiment Runners, Theorists |
| Experiment Data | A State field that holds observations which correspond to the specified conditions. | Experiment Runners, Theorists |
| Model | A State field that holds the the collection of best fit equations produced by theorists. | Theorists, Experimentalists |
| Components | The distinct yet flexible capabilities of the AutoRA framework. | Experimentalists, Experiment Runners, Theorists |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't very descriptive. Might want to change to something like "the objects that can act on the state - e.g., experimentalists, experiment runners, theorists."?

| Experiment Data | A State field that holds observations which correspond to the specified conditions. | Experiment Runners, Theorists |
| Model | A State field that holds the the collection of best fit equations produced by theorists. | Theorists, Experimentalists |
| Components | The distinct yet flexible capabilities of the AutoRA framework. | Experimentalists, Experiment Runners, Theorists |
| Experimentalist | A module that takes in models and outputs new conditions, which are intended to yield novel observations. | Experimentalists |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the word module here and in the next two, but with Components explicitly defined, should we use that terminology instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, not all experimentalists take in models.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should maybe update the core diagram that we use throughout the user guide then: https://autoresearch.github.io/autora/img/experimentalist.png

| Model | A State field that holds the the collection of best fit equations produced by theorists. | Theorists, Experimentalists |
| Components | The distinct yet flexible capabilities of the AutoRA framework. | Experimentalists, Experiment Runners, Theorists |
| Experimentalist | A module that takes in models and outputs new conditions, which are intended to yield novel observations. | Experimentalists |
| Theorist | A module that takes in the full collection of conditions and observations and outputs equations that link the two (i.e., models) | Theorists |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say outputs models instead of equations because they don't always have to output an equation (although all of ours currently do).

Copy link
Collaborator

@chadcwilliams chadcwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! I have some comments, but nothing major. Feel free to ignore the comments if you don't agree!

docs/terminology.md Outdated Show resolved Hide resolved
docs/terminology.md Outdated Show resolved Hide resolved
docs/terminology.md Outdated Show resolved Hide resolved
docs/terminology.md Outdated Show resolved Hide resolved
docs/terminology.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@chadcwilliams chadcwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Still one comment, but just a thought, not a necessary change.

docs/terminology.md Outdated Show resolved Hide resolved
@hollandjg
Copy link
Member

Hi @benwandrew, thanks for this! I'd love to look at this PR, but I won't get to it until next week. Can you keep it open until then? Thanks!

Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @benwandrew , thanks for hanging fire on this one. This is extremely valuable!
I've got a couple of questions and suggestions.

docs/terminology.md Outdated Show resolved Hide resolved
docs/terminology.md Outdated Show resolved Hide resolved
docs/terminology.md Outdated Show resolved Hide resolved
docs/terminology.md Outdated Show resolved Hide resolved
docs/terminology.md Outdated Show resolved Hide resolved
docs/terminology.md Outdated Show resolved Hide resolved
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@benwandrew benwandrew added this pull request to the merge queue Oct 27, 2023
Merged via the queue into main with commit 5ce58b0 Oct 27, 2023
15 checks passed
@benwandrew benwandrew deleted the docs/make-a-documentation-page-outlining-the-terminology-based-on-the-spreadsheet branch October 27, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a documentation page outlining the terminology (based on the spreadsheet)
3 participants