Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/kzg gadget full #906

Closed
wants to merge 15 commits into from
Closed

Feat/kzg gadget full #906

wants to merge 15 commits into from

Conversation

ThomasPiellard
Copy link
Collaborator

Description

Addition of BatchVerifySinglePoint, BatchVerifyMultiPoints, FoldProof in KZG gadget.

Will conflict with #900

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • TestBatchVerifySinglePoint
  • TestBatchVerifyMultiPoints
  • TestFoldProof

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ThomasPiellard ThomasPiellard requested a review from ivokub November 7, 2023 15:13
@ivokub ivokub mentioned this pull request Nov 8, 2023
Merged
@ivokub
Copy link
Collaborator

ivokub commented Nov 10, 2023

I think we can close after #908 being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivokub ivokub Awaiting requested review from ivokub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasPiellard @ivokub