Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Resources section #12

Closed
wants to merge 38 commits into from
Closed

Set up Resources section #12

wants to merge 38 commits into from

Conversation

Dindihub
Copy link
Owner

@Dindihub Dindihub commented Aug 9, 2024

Set up and population of the TUF.io Resources section.

Please review @chalin

Dindihub and others added 30 commits August 7, 2024 14:03
Signed-off-by: sandra <[email protected]>
Signed-off-by: sandra <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Signed-off-by: sandra <[email protected]>
Signed-off-by: sandra <[email protected]>
Signed-off-by: sandra <[email protected]>
Signed-off-by: sandra <[email protected]>
Signed-off-by: sandra <[email protected]>
Signed-off-by: sandra <[email protected]>
Signed-off-by: sandra <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for tufresources ready!

Name Link
🔨 Latest commit ba262d0
🔍 Latest deploy log https://app.netlify.com/sites/tufresources/deploys/66b647742e4fa7000836a50d
😎 Deploy Preview https://deploy-preview-12--tufresources.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

content/en/resources/news.md Show resolved Hide resolved
content/en/resources/_index.md Show resolved Hide resolved
content/en/resources/_index.md Show resolved Hide resolved
content/en/resources/news.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@chalin
Copy link
Collaborator

chalin commented Aug 9, 2024

Hmm, just like cncf/techdocs#272, this PR has 38 commits, which doesn't make sense. Again, I think that you need to rebase it, and then force push the changes.

@Dindihub
Copy link
Owner Author

Hmm, just like cncf/techdocs#272, this PR has 38 commits, which doesn't make sense. Again, I think that you need to rebase it, and then force push the changes.

Noted. Thanks

@Dindihub Dindihub closed this Aug 10, 2024
@Dindihub Dindihub deleted the resources branch August 10, 2024 11:53
@Dindihub Dindihub mentioned this pull request Aug 10, 2024
@chalin
Copy link
Collaborator

chalin commented Aug 11, 2024

Thanks for creating a new PR. In the future, when closing and reopening a new PR, ensure that you address all comments in the "old" PR, and mark comments with a thumbs up once you have addressed them. While you addressed the press-release page comment I made here in #13, my other comments were not addressed. For this time, I've repeated (and adjusted) them over in #13.

@Dindihub
Copy link
Owner Author

Dindihub commented Aug 12, 2024

Thanks for creating a new PR. In the future, when closing and reopening a new PR, ensure that you address all comments in the "old" PR, and mark comments with a thumbs up once you have addressed them. While you addressed the press-release page comment I made here in #13, my other comments were not addressed. For this time, I've repeated (and adjusted) them over in #13.

Thanks for creating a new PR. In the future, when closing and reopening a new PR, ensure that you address all comments in the "old" PR, and mark comments with a thumbs up once you have addressed them. While you addressed the press-release page comment I made here in #13, my other comments were not addressed. For this time, I've repeated (and adjusted) them over in #13.

@chalin Sorry, my mistake. Thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants