Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Resources section #13

Merged
merged 11 commits into from
Aug 19, 2024
Merged

Set up Resources section #13

merged 11 commits into from
Aug 19, 2024

Conversation

Dindihub
Copy link
Owner

@Dindihub Dindihub commented Aug 10, 2024

@chalin Created a new resources PR to solve commit issues in PR #12

The deploy preview from tufresources link is more accurate for this branch. Please review. Thanks

Copy link

netlify bot commented Aug 10, 2024

Deploy Preview for tufresources ready!

Name Link
🔨 Latest commit 062e125
🔍 Latest deploy log https://app.netlify.com/sites/tufresources/deploys/66b9fffb79b4830008f572ee
😎 Deploy Preview https://deploy-preview-13--tufresources.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Dindihub Dindihub changed the title Resources Set up Resources section Aug 10, 2024
Dindihub and others added 6 commits August 10, 2024 19:57
Signed-off-by: sandra <[email protected]>
Dindihub and others added 4 commits August 12, 2024 15:19
@Dindihub
Copy link
Owner Author

Dindihub commented Aug 12, 2024

@chalin I've addressed your comments from #12. I'm ready to close this one and move to the other issues upon your approval. Thanks

@Dindihub Dindihub requested review from lukpueh and chalin August 13, 2024 07:11
@lukpueh
Copy link
Collaborator

lukpueh commented Aug 13, 2024

The deploy preview from tufresources link is more accurate for this branch.

Out of curiosity, why are there two deployment previews?

Copy link
Collaborator

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Can I ask you a favor? Would you mind clicking all links that you added in this PR, which, I suppose, you copied from theupdateframework.io, and list the ones that don't work in a new issue in the upstream repo? --> https://github.com/theupdateframework/theupdateframework.io/issues

@Dindihub
Copy link
Owner Author

The deploy preview from tufresources link is more accurate for this branch.

Out of curiosity, why are there two deployment previews?

My mistake. I was having trouble configuring the Netlify build on the main branch so I added the preview to this branch too. But I'll delete it to avoid confusion.

@Dindihub
Copy link
Owner Author

Looks great!

Can I ask you a favor? Would you mind clicking all links that you added in this PR, which, I suppose, you copied from theupdateframework.io, and list the ones that don't work in a new issue in the upstream repo? --> https://github.com/theupdateframework/theupdateframework.io/issues

Sure. No problem. And thanks for the review.

Repository owner deleted a comment from netlify bot Aug 13, 2024
@Dindihub Dindihub merged commit 7205174 into main Aug 19, 2024
10 checks passed
@chalin chalin deleted the resources branch August 28, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants