-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge press and news pages #17
Conversation
✅ Deploy Preview for tufio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the missing white space and check with @chalin about the aliases, otherwise, this looks great! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'd like for you to pull in the changes that I just merged first so that we can test the aliases. That is, the following should successfully redirect:
@chalin unfortunately, the aliases are not redirecting |
You need to rebase in order for the aliases to start working. |
Signed-off-by: sandra <[email protected]>
Signed-off-by: sandra <[email protected]>
Signed-off-by: sandra <[email protected]>
Signed-off-by: sandra <[email protected]>
Signed-off-by: sandra <[email protected]>
Co-authored-by: Lukas Pühringer <[email protected]>
Signed-off-by: sandra <[email protected]>
Signed-off-by: sandra <[email protected]>
Signed-off-by: sandra <[email protected]>
fcd2968
to
1b05559
Compare
I've rebased for you. If you'd like to try it on your own another time, the commands to use are something like this: git switch main
git pull
git switch press-news-merge
git rebase main
git push -f |
Aliases are working now, as expected. I believe that this addresses all previously raised concerns, so let's merge this now. |
This PR covers issue #15
I would appreciate your input @chalin @lukpueh