Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another announcer #372

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file added Resources/Audio/Announcers/_ACES/fallback.ogg
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
1 change: 1 addition & 0 deletions Resources/Locale/en-US/_LostParadise/update20.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ trait-desc-DwarfLanguage = Если не вслушиваться похоже
changelog-tab-title-ChangelogLPP = Обновления Lost Paradise
announcer-NTH-name = N.T.H.
announcer-AFONYA-name = C.A.S.S.I.E.
announcer-ACES-name = A.C.E.S
chatsan-awoo = воет
chatsan-hiss = шипит
chatsan-nyaaa = някает
Expand Down
1 change: 1 addition & 0 deletions Resources/Locale/ru-RU/_LostParadise/update20.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ trait-desc-DwarfLanguage = Если не вслушиваться похоже
changelog-tab-title-ChangelogLPP = Обновления Lost Paradise
announcer-NTH-name = N.T.H.
announcer-AFONYA-name = C.A.S.S.I.E.
announcer-ACES-name = A.C.E.S
chatsan-awoo = воет
chatsan-hiss = шипит
chatsan-nyaaa = някает
Expand Down
5 changes: 3 additions & 2 deletions Resources/Prototypes/Announcers/!randomAnnouncers.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
- type: weightedRandom
id: RandomAnnouncers
weights:
NTH: 0.5
AFONYA: 0.5
NTH: 0.33
AFONYA: 0.33
ACES: 0.33
134 changes: 134 additions & 0 deletions Resources/Prototypes/_LostParadise/Announcers/ACES.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,134 @@
- type: announcer
id: ACES # Localized as "announcer-<id>-name" in chat
basePath: /Audio/Announcers/_ACES # Where to start looking for audio files
baseAudioParams: # Default audio parameters for all announcements, all options explained in the template announcement
volume: -1 # If this announcer is really loud, lower it to match the others' volume #? Default is 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Громкость диктора требует корректировки

Анализ других конфигураций дикторов показывает, что значение -1 действительно нестандартное. Типичные значения громкости:

  • Шаблон (template): -7
  • Michael: -3
  • Neil: -3
  • Intern: -7

Рекомендуется установить громкость в диапазоне от -7 до -3, чтобы соответствовать существующим дикторам. Значение -1 может сделать диктора слишком громким по сравнению с остальными.

🔗 Analysis chain

Проверьте настройку громкости

Значение громкости -1 кажется нестандартным. Рекомендуется:

  1. Сравнить с громкостью других дикторов
  2. Уточнить значение по умолчанию (в комментарии указано неуверенное значение)
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Поиск настроек громкости в других конфигурациях дикторов
rg "volume:" Resources/Prototypes/Announcers/

Length of output: 533

announcements: # List of all announcements this announcer has audio for #! Comment out unused announcements, don't remove them
# Communications
- id: announce # Communications console
path: comms/announce.ogg
- id: attention # Generic alert sound # Should be different from fallback but it's very similar
path: comms/attention.ogg
- id: commandReport # Station goal, Central Command messages, etc
path: comms/command_report.ogg
# - id: spawnAnnounce # Captain join # TODO That system is annoyingly not modular
# path: comms/spawn_announce.ogg
Comment on lines +14 to +15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Требуется доработка системы spawnAnnounce

TODO комментарий указывает на проблему с модульностью системы. Рекомендуется создать задачу для улучшения модульности этой функциональности.

Хотите, чтобы я создал GitHub Issue для отслеживания этой задачи?

- id: war # Nuclear Operative declaration of war
path: comms/war.ogg
# - id: nukeCodes # The station has been send nuclear activation codes
# path: comms/nuke_codes.ogg # Or command_report.ogg if you want
# - id: nukeArm # The nuke is active and ticking
# path: comms/nuke_arm.ogg
# - id: nukeDisarm # The nuke has been disarmed
# path: comms/nuke_disarm.ogg
- id: welcome # The shift has started
collection: ACESWelcome

# Alert levels
- id: alertGreen # Everything is fine
path: alerts/green.ogg
- id: alertBlue # Something is amiss
path: alerts/blue.ogg
- id: alertViolet # Viral infection or misc medical emergencies, listen to Medical
path: alerts/violet.ogg
- id: alertWhite # Glimmer is too high, listen to Epistemics
path: alerts/white.ogg
- id: alertYellow # The station is being largely damaged, listen to Engineering
path: alerts/yellow.ogg
- id: alertRed # Generic many things are bad, listen to Security
path: alerts/red.ogg
- id: alertGamma # There is a massive immediate threat to the station, listen to Central Command
path: alerts/gamma.ogg
- id: alertDelta # The station is being or about to be massively destroyed, run for your life
path: alerts/delta.ogg
- id: alertEpsilon # The station has been terminated, good luck survivors!
path: alerts/epsilon.ogg

# Events
## Wizard's Den
### Mid-Round Antagonists
- id: ninjaHacking # A Ninja is hacking something
path: comms/ninja_hacking.ogg
- id: powersinkExplosion # A power sink is about to overcharge and explode
path: comms/powersink_explosion.ogg
### Events
- id: anomalySpawn # An anomaly has spawned in a random place
path: events/anomaly.ogg
- id: bluespaceArtifact # An artifact has spawned in a random place
path: events/bluespace_artifact.ogg
# - id: bluespaceLocker # Two random lockers now share inventories
# path: events/bluespace_locker.ogg
- id: breakerFlip # A few random APCs have been disabled, ask Engineering to fix them
path: events/breaker_flip.ogg
- id: bureaucraticError # Random jobs have been added, removed, or made infinite
path: events/bureaucratic_error.ogg
- id: clericalError # Random crew are removed from the manifest
path: events/clerical_error.ogg
- id: carpRift # A dragon's carp rift is active
path: events/carp_rift.ogg
- id: revenantSpawn # A revenant has spawned (by a prober?)
path: events/revenant_spawn.ogg
- id: gasLeak # A random gas is coming out of a random vent
path: events/gas_leak.ogg
- id: gasLeakComplete # Gas has stopped coming out of a vent
path: events/gas_leak-complete.ogg
- id: kudzuGrowth # Kudzu is growing in a random place
path: events/kudzu_growth.ogg
- id: meteorSwarm # Meteors are flying at the station, stay away from windows
path: events/meteors.ogg
- id: meteorSwarmComplete # Meteors have stopped flying at the station
path: events/meteors-complete.ogg
- id: mouseMigration # Several mice have appeared in a random place
path: events/mouse_migration.ogg
- id: cockroachMigration # Several cockroaches have appeared in a random place
path: events/migration.ogg
Comment on lines +82 to +84
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Рассмотрите возможность уникальных звуков для разных событий

Несколько разных событий используют один и тот же файл migration.ogg:

  • Миграция мышей
  • Миграция тараканов
  • Появление слизней
  • Появление пауков

Рекомендуется создать уникальные звуки для каждого типа события для лучшего различения.

Also applies to: 97-100

- id: powerGridCheck # The station's power is offline for some moments
path: events/power_grid_check.ogg
- id: powerGridCheckComplete # The station's power is online again
path: events/power_grid_check-complete.ogg
- id: randomSentience # A random few animals have become sentient
path: events/random_sentience.ogg
- id: solarFlare # A solar flare is nearby, may mess with comms and electronics
path: events/solar_flare.ogg
- id: solarFlareComplete # The solar flare has passed
path: events/solar_flare-complete.ogg
- id: ventClog # A random reagent is coming out of a scrubber
path: events/vent_clog.ogg
- id: slimesSpawn # Some simple slimes are appearing in vents
path: events/migration.ogg
- id: spiderSpawn # Some simple spiders are appearing in vents
path: events/migration.ogg
- id: immovableRodSpawn # The station is moving into an immovable rod, don't die or something, ask Engineering for help repairing it
path: events/immovable_rod_spawn.ogg
- id: ionStorm # AI-controlled equipment are now weird, check their laws
path: events/ion_storm.ogg
## Delta-V
# - id: xenoVents # Xenomorphs are coming out of vents
# path: events/aliens.ogg
## NyanoTrasen
- id: noosphericStorm # A large amount of glimmer has joined the station and made people psionic
path: events/noospheric_storm.ogg

# Shuttle
- id: shuttleCalled # The shuttle is on its way
path: shuttle/called.ogg
- id: shuttleRecalled # The shuttle is going back to Central Command
path: shuttle/recalled.ogg
- id: shuttleDock # The shuttle has arrived at the station
path: shuttle/docked.ogg
# - id: shuttleNearby # The shuttle couldn't dock, it's at a specified location
# path: shuttle/nearby.ogg
# - id: shuttleGoodLuck # The shuttle could not find its way to the station, good luck crew
# path: shuttle/good_luck.ogg
# - id: shuttleAuthAdded # One of few have added their acceptance to early launching
# path: shuttle/auth_added.ogg
# - id: shuttleAuthRevoked # One of few have revoked their acceptance to early launching
# path: shuttle/auth_revoked.ogg
# - id: shuttleAlmostLaunching # The shuttle will leave to FTL in 10 seconds
# path: shuttle/almost_launching.ogg
- id: shuttleLeft # The shuttle has left the station
path: shuttle/left.ogg

# Fallback # REQUIRED
- id: fallback # Any announcement sent without a valid announcement on this announcer will use this
path: fallback.ogg
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,9 @@
files:
- /Audio/Announcers/_NTH/comms/welcome1.ogg
- /Audio/Announcers/_NTH/comms/welcome2.ogg

- type: soundCollection
id: ACESWelcome
files:
- /Audio/Announcers/_ACES/comms/malf.ogg
- /Audio/Announcers/_ACES/comms/announce.ogg
Loading