Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statping-ng: init at 0.91.0 #371906

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

statping-ng: init at 0.91.0 #371906

wants to merge 2 commits into from
+175 −0

Conversation

FKouhai
Copy link

@FKouhai FKouhai commented Jan 7, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@FKouhai
Copy link
Author

FKouhai commented Jan 7, 2025

this should close #364364

@FKouhai FKouhai mentioned this pull request Jan 7, 2025
Closed
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 7, 2025
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 7, 2025
@FKouhai FKouhai force-pushed the contrib branch 2 times, most recently from bc07339 to 08b99f5 Compare January 9, 2025 07:53
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 9, 2025
@teto
Copy link
Member

teto commented Jan 10, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371906

x86_64-linux

❌ 1 package failed to build:
  • statping-ng

@FKouhai
Copy link
Author

FKouhai commented Jan 10, 2025 •
edited
Loading

@teto interesting, im running

nix-shell -p nixpkgs-review --run "nixpkgs-review pr 371906"

--------- Report for 'x86_64-linux' ---------
1 package built:
statping-ng

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371906

x86_64-linux

✅ 1 package built:
  • statping-ng

@FKouhai
Copy link
Author

FKouhai commented Jan 10, 2025

updated linux aarch64 hash

@FKouhai
Copy link
Author

FKouhai commented Jan 10, 2025

do not merge yet, I need to update the hash for the darwin build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FKouhai @teto