Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] l10n_be_cooperator_national_number #119

Merged

Conversation

victor-champonnois
Copy link
Member

Internal task : https://gestion.coopiteasy.be/web#id=12260&model=project.task&view_type=form&menu_id=
Now depends on l10n_be_partner_identification rather than l10n_be_national_number

victor-champonnois and others added 19 commits March 15, 2024 13:59
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
In some scenarios, the migration is run on a database that does not yet
have the requisite fields in the database. By making it a post-migration
script, we avoid the problem.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@victor-champonnois victor-champonnois changed the title [16.0][MIG] l10n be cooperator national number [16.0][MIG] l10n_be_cooperator_national_number Mar 15, 2024
@victor-champonnois victor-champonnois force-pushed the 16.0-mig-l10n_be_cooperator_national_number branch from 4c347c2 to 656be6b Compare March 15, 2024 13:32
@victor-champonnois victor-champonnois force-pushed the 16.0-mig-l10n_be_cooperator_national_number branch from 656be6b to 3f2b5ef Compare March 15, 2024 13:46
rather than on l10n_be_national_number (in v14)
@victor-champonnois victor-champonnois force-pushed the 16.0-mig-l10n_be_cooperator_national_number branch from 3f2b5ef to 39bdd4d Compare March 15, 2024 13:50
Copy link

@polchampion polchampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successful functional test

@polchampion
Copy link

@carmenbianca Could you review this? and if you have the power, approve the pr?

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Copy link
Member

@carmenbianca carmenbianca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made one adjustment, LGTM

@carmenbianca
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-119-by-carmenbianca-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 29, 2024
Signed-off-by carmenbianca
@OCA-git-bot
Copy link
Contributor

@carmenbianca your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-119-by-carmenbianca-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

1 similar comment
@OCA-git-bot
Copy link
Contributor

@carmenbianca your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-119-by-carmenbianca-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@carmenbianca
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-119-by-carmenbianca-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7fc3e4d into OCA:16.0 May 2, 2024
1 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5c1327b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants