[18.0][MIG] mail_tracking: Migration to 18.0 #1476

trisdoan · 2024-10-17T05:07:17Z

Note

missing commits from 14.0 are ported in [17.0][FW] Port missing commits #1475

Big changes in 18.0

Backend

access_rights_uid was removed from _search() changed in odoo/odoo@21d023e
_prepare_outgoing_list got extra param mail_server in odoo/odoo@97ce084
_message_format was converted to use store and message_format_extras was removed in odoo/odoo@52df49e. As consequences, _extras_to_store is introduced
tools.ustr is considered to be inefficient and flagged as deprecated in odoo/odoo@64a5724. Hence, is replaced by exception_to_unicode for the same effect.

Frontend

mail.messaging service was removed in odoo/odoo@683258b
initMessagingCallback is removed in odoo/odoo@4f8087f. So new entry point is created for store onStarted instead.
mail.thread service was removed in odoo/odoo@65e5a79

This changes

Store helper was introduced in odoo/odoo@c032ccf. As consequences, failed data is now passed through Store.
- As a side effect, it is also easier to do the search filter_failed(thread) with Store service
As Odoo uses less Jquery, the module runs fine with vanilla. This impacts mail_tracking/static/src/components/message_tracking/message_tracking.esm.js
Took this chance to
- replace % format with f-string
- Improve permission constraint
  - Context: This commit porting from 12.0
  - Approach is summarized as below:
    1. When do the searching,
      - First, use the query to get result
      - Browse those id with the query + Remove any forbidden records
      - Return the accessible records in form of query, to continue the process
    2. When user read the records
      - The low-level method _check_access will discard forbidden records + raise exception
  - Added security check test
- Resolve FIXME, which was added in 7560443, then was resolved in odoo/odoo@7fe02c9

Result

trisdoan · 2024-10-17T05:10:20Z

~~DRAFT: working on failed test~~

~~> 2024-10-17 05:08:43,628 246 WARNING odoo odoo.addons.mail_tracking.controllers.main: MailTracking email '11' not found~~

pedrobaeza · 2024-10-17T06:00:21Z

/ocabot migration mail_tracking

chienandalu

Huge work @trisdoan !

I should try with a real mail configuration. For the moment:

Installing the module in runboat doesn't load for me the demo failed messages for retry (I saw in them in your screenshot thou...)

chienandalu · 2024-10-17T07:01:06Z

mail_tracking/models/mail_message.py

@@ -29,7 +30,7 @@ class MailMessage(models.Model):
    )
    is_failed_message = fields.Boolean(
        compute="_compute_is_failed_message",
-        search="_search_is_failed_message",
+        store=True,


Do we really need to make it stored?

Hi, this flag is used to populate the controller: /mail/failed/messages

Please don't change how it was, no stored and with search method. Or does any reason for changing it?

Hi @pedrobaeza, yes I agree there is no need to store it in db. But look like the search method is not working.

I am working on it, will update when it's done

Hi @pedrobaeza @chienandalu , I just added fixup! [MIG] mail_tracking: Migration to 18.0 (will squash after we all agree)

As I inspected, _search_is_failed_message was not working. Without this commit, the condition in final query is always False => return no result

I added a test to make sure it's covered

trisdoan · 2024-10-21T04:30:33Z

~~DRAFT: inspect _search_is_failed_message~~

pedrobaeza · 2024-10-21T18:52:42Z

What do you think about #1458 (comment) ?

* [ADD] mail_tracking addon * Add description icon * Fixes remarked * Fix Travis error * Remarks fixed

…ent events (OCA#82) [IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes

* Improve tests * Show trackings even if partner removed * Disable CSRF protection to webhooks controllers

…s and contacts to bounce (OCA#133)

…oved (OCA#132)

As regular users can't access this object.

Currently translated at 82.4% (103 of 125 strings) Translation: social-16.0/social-16.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking/pt_BR/

Currently translated at 29.8% (34 of 114 strings) Translation: social-15.0/social-15.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_tracking/it/

Currently translated at 100.0% (125 of 125 strings) Translation: social-16.0/social-16.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking/fr/

TT49060

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_tracking/

Currently translated at 100.0% (128 of 128 strings) Translation: social-17.0/social-17.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_tracking/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_tracking/

Add autovacuum to mail_tracking_email that removes old records based on new configuration variable mail_tracking_email_max_age_days. Due to possibly a large number of records to be deleted on first run, set a default limit of 5000 per run.

ivantodorovich

Code review. LG. Thanks!

chienandalu

Looks very good overall. In the testing side, I'm missing reactivity for the failed message actions. An example, where the failed message card should go away (it only does when we reload the window):

Also, can you squash your migration commits?

trisdoan · 2024-10-28T07:58:19Z

Looks very good overall. In the testing side, I'm missing reactivity for the failed message actions. An example, where the failed message card should go away (it only does when we reload the window):

Hi @chienandalu , yes you're right. It causes confusion indeed.

My approach is to reload the page: browser.location.reload();
What do you think?

Look like it gets the same issue in 17.0

pedrobaeza · 2024-11-05T08:02:21Z

Now that OCA/mail has been created (OCA/repo-maintainer-conf#52), can you please move this PR to that repo?

trisdoan · 2024-11-05T08:56:24Z

Superseded by OCA/mail#1

trisdoan mentioned this pull request Oct 17, 2024

Migration to version 18.0 #1458

Open

26 tasks

trisdoan marked this pull request as draft October 17, 2024 05:09

trisdoan mentioned this pull request Oct 17, 2024

[18.0][MIG] mail_tracking_mass_mailing: Migration to 18.0 #1478

Closed

trisdoan marked this pull request as ready for review October 17, 2024 05:24

trisdoan force-pushed the 18.0-mig-mail_tracking branch from df5d6c7 to 794a168 Compare October 17, 2024 05:24

OCA-git-bot added this to the 18.0 milestone Oct 17, 2024

pedrobaeza requested a review from chienandalu October 17, 2024 06:00

chienandalu reviewed Oct 17, 2024

View reviewed changes

trisdoan marked this pull request as draft October 21, 2024 04:29

trisdoan force-pushed the 18.0-mig-mail_tracking branch 2 times, most recently from 34f41c7 to c9c296f Compare October 23, 2024 02:29

antespi and others added 15 commits October 23, 2024 09:31

[8.0][ADD] mail_tracking addon (OCA#67)

fafd37b

* [ADD] mail_tracking addon * Add description icon * Fixes remarked * Fix Travis error * Remarks fixed

[8.0][IMP][mail_tracking] Speed installation time and discard concurr…

c848106

…ent events (OCA#82) [IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes

[FIX] Update email_score when email changes

60ce36b

[MIG] mail_tracking

ca63b03

* Improve tests * Show trackings even if partner removed * Disable CSRF protection to webhooks controllers

[FIX] mail_tracking: Typo

aaa07bd

[MIG] Make modules uninstallable

f136c28

[MIG] mail_tracking: Migrated to 10.0

a2f6a58

[IMP] mail_tracking performance and bounce process (OCA#103)

ae9b8e8

[IMP] mail_tracking: Allow to define a custom mail_tracking base url

b9b495b

Add access to portal/public user to his own email trackings

5e45102

[8.0][FIX][mail_tracking] Use event recipient address to find partner…

1f25c13

…s and contacts to bounce (OCA#133)

[9.0][FIX][mail_tracking] Control exception when mail_message was rem…

e0c15fc

…oved (OCA#132)

[FIX] Sender label is repeated in search fields

e5cb243

[FIX][9.0] partner buttons view on enterprise

7cbfa16

[FIX] mail_tracking: Obtain outgoing server with sudo

dc32136

As regular users can't access this object.

NiChrDeuse and others added 17 commits October 23, 2024 09:31

[16.0][FIX] mail_tracking debug mode error

710a9be

Translated using Weblate (Portuguese (Brazil))

662e6d8

Currently translated at 82.4% (103 of 125 strings) Translation: social-16.0/social-16.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking/pt_BR/

Translated using Weblate (Italian)

ec43a1b

Currently translated at 29.8% (34 of 114 strings) Translation: social-15.0/social-15.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_tracking/it/

Translated using Weblate (French)

3a9888d

Currently translated at 100.0% (125 of 125 strings) Translation: social-16.0/social-16.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking/fr/

[IMP] mail_tracking: Give example that actually works in readme

e221ae2

[FIX] mail_tracking: be closer to what Odoo does in a nodb environment

64f5233

[IMP] mail_tracking: pre-commit auto fixes

760c064

[MIG] mail_tracking: Migration to 17.0

c67530c

TT49060

[UPD] Update mail_tracking.pot

8a56fed

[BOT] post-merge updates

d4c2fd4

Update translation files

034b1ce

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_tracking/

Translated using Weblate (Italian)

ed7bf56

Currently translated at 100.0% (128 of 128 strings) Translation: social-17.0/social-17.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_tracking/it/

[UPD] Update mail_tracking.pot

f02001e

Update translation files

5e5998f

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_tracking/

[IMP] Add option to keep aliases in mail tracking

9a79df5

mail_tracking: add garbage collection

1fd3529

Add autovacuum to mail_tracking_email that removes old records based on new configuration variable mail_tracking_email_max_age_days. Due to possibly a large number of records to be deleted on first run, set a default limit of 5000 per run.

[FW] port missing commits from 14.0 to 17.0

fc98019

trisdoan force-pushed the 18.0-mig-mail_tracking branch from c9c296f to 8bcec37 Compare October 23, 2024 02:36

[IMP] mail_tracking: pre-commit auto fixes

f98b34c

trisdoan force-pushed the 18.0-mig-mail_tracking branch from 8bcec37 to a6bce24 Compare October 23, 2024 02:47

trisdoan marked this pull request as ready for review October 23, 2024 02:48

ivantodorovich approved these changes Oct 24, 2024

View reviewed changes

chienandalu reviewed Oct 25, 2024

View reviewed changes

[MIG] mail_tracking: Migration to 18.0

e992629

trisdoan force-pushed the 18.0-mig-mail_tracking branch from a6bce24 to e992629 Compare October 28, 2024 07:53

trisdoan closed this Nov 5, 2024

chienandalu mentioned this pull request Nov 5, 2024

[18.0][MIG] mail_tracking: Migration to 18.0 OCA/mail#1

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] mail_tracking: Migration to 18.0 #1476

[18.0][MIG] mail_tracking: Migration to 18.0 #1476

trisdoan commented Oct 17, 2024 •

edited

Loading

trisdoan commented Oct 17, 2024 •

edited

Loading

pedrobaeza commented Oct 17, 2024

chienandalu left a comment

chienandalu Oct 17, 2024

trisdoan Oct 18, 2024

pedrobaeza Oct 18, 2024

trisdoan Oct 21, 2024

trisdoan Oct 23, 2024 •

edited

Loading

trisdoan commented Oct 21, 2024 •

edited

Loading

pedrobaeza commented Oct 21, 2024

ivantodorovich left a comment

chienandalu left a comment

trisdoan commented Oct 28, 2024 •

edited

Loading

pedrobaeza commented Nov 5, 2024

trisdoan commented Nov 5, 2024

[18.0][MIG] mail_tracking: Migration to 18.0 #1476

[18.0][MIG] mail_tracking: Migration to 18.0 #1476

Conversation

trisdoan commented Oct 17, 2024 • edited Loading

Note

Big changes in 18.0

Backend

Frontend

This changes

Result

trisdoan commented Oct 17, 2024 • edited Loading

pedrobaeza commented Oct 17, 2024

chienandalu left a comment

Choose a reason for hiding this comment

chienandalu Oct 17, 2024

Choose a reason for hiding this comment

trisdoan Oct 18, 2024

Choose a reason for hiding this comment

pedrobaeza Oct 18, 2024

Choose a reason for hiding this comment

trisdoan Oct 21, 2024

Choose a reason for hiding this comment

trisdoan Oct 23, 2024 • edited Loading

Choose a reason for hiding this comment

trisdoan commented Oct 21, 2024 • edited Loading

pedrobaeza commented Oct 21, 2024

ivantodorovich left a comment

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

trisdoan commented Oct 28, 2024 • edited Loading

pedrobaeza commented Nov 5, 2024

trisdoan commented Nov 5, 2024

trisdoan commented Oct 17, 2024 •

edited

Loading

trisdoan commented Oct 17, 2024 •

edited

Loading

trisdoan Oct 23, 2024 •

edited

Loading

trisdoan commented Oct 21, 2024 •

edited

Loading

trisdoan commented Oct 28, 2024 •

edited

Loading