Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change the way to get default KMS for EBS #101

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

slawomir-kaczmarek
Copy link
Contributor

Description

PR fixes the way to get default KMS for EBS in all examples and Panorama and VM-Series modules.

Motivation and Context

#98

How Has This Been Tested?

Tested locally using terraform plan command

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@slawomir-kaczmarek slawomir-kaczmarek requested a review from a team as a code owner January 21, 2025 22:02
@slawomir-kaczmarek slawomir-kaczmarek self-assigned this Jan 21, 2025
@slawomir-kaczmarek
Copy link
Contributor Author

slawomir-kaczmarek commented Jan 21, 2025

/apply paths="examples/centralized_design_autoscale examples/combined_design_autoscale examples/isolated_design examples/panorama_standalone examples/vmseries_standalone"

Testing job ID: 12896872491
Job result: SUCCESS

@slawomir-kaczmarek slawomir-kaczmarek merged commit 2113af9 into main Jan 22, 2025
112 checks passed
@slawomir-kaczmarek slawomir-kaczmarek deleted the ebs-kms-alias branch January 22, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Incorrect config in the Combined_design_autoscale
3 participants