This repository has been archived by the owner on May 15, 2023. It is now read-only.
Slash key on month input selects year input #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +14,7 @@ | |||
| <link rel="import" href="../paper-input/paper-input-container.html"> | |||
| <link rel="import" href="../paper-styles/default-theme.html"> | |||
| <link rel="import" href="../paper-styles/typography.html"> | |||
| <link rel="import" href="../iron-a11y-keys/iron-a11y-keys.html"> | |||
There was a problem hiding this comment.
You should use the iron-a11y-keys-behavior instead; it's more performant (keys is just the behavior wrapped in an element, which isn't needed).
|
Thanks for your contribution! This is an awesome feature! I left a couple of comments for you. |
|
Closing this, since there's hasn't been any response to the review. Please re-open this when it's ready for another look! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a date typed with a slash to populate the inputs (eg: '2/16')
Fixes #36