Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Slash key on month input selects year input #42

Closed
wants to merge 1 commit into from
+16 −0
Closed

Slash key on month input selects year input #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"iron-validatable-behavior": "PolymerElements/iron-validatable-behavior#^1.0.0",
"iron-flex-layout": "PolymerElements/iron-flex-layout#^1.0.0",
"iron-form-element-behavior": "PolymerElements/iron-form-element-behavior#^1.0.0",
"iron-a11y-keys": "PolymerElements/iron-a11y-keys#^1.0.0",
"paper-input": "PolymerElements/paper-input#^1.0.0",
"paper-styles": "PolymerElements/paper-styles#^1.0.0",
"polymer": "Polymer/polymer#^1.1.0"
Expand Down
15 changes: 15 additions & 0 deletions date-input.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<link rel="import" href="../paper-input/paper-input-container.html">
<link rel="import" href="../paper-styles/default-theme.html">
<link rel="import" href="../paper-styles/typography.html">
<link rel="import" href="../iron-a11y-keys/iron-a11y-keys.html">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use the iron-a11y-keys-behavior instead; it's more performant (keys is just the behavior wrapped in an element, which isn't needed).


<link rel="import" href="date-validator.html">

Expand Down Expand Up @@ -54,8 +55,11 @@
<span aria-hidden id="monthLabel" hidden>Month</span>
<span aria-hidden id="yearLabel" hidden>Year</span>

<iron-a11y-keys id="a11y-month" target="[[expirationMonth]]" keys="/"
on-keys-pressed="_selectYear"></iron-a11y-keys>
<div class="container">
<input is="iron-input"
id="expirationMonth"
aria-labelledby$="[[_computeAriaLabel(ariaLabelPrefix,'monthLabel')]]"
required$="[[required]]"
maxlength="2"
Expand Down Expand Up @@ -119,6 +123,13 @@
type: String
},

expirationMonth: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think once you use the behavior, this won't be needed anymore

type: Object,
value: function() {
return this.$.expirationMonth;
}
},

/**
* The year component of the date displayed.
*/
Expand Down Expand Up @@ -159,6 +170,10 @@
}
},

_selectYear: function() {
this.$.expirationYear.select();
},

validate: function() {
// Empty, non-required input is valid.
if (!this.required && this.month == '' && this.year == '') {
Expand Down