Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize favicon and open graph data across Nebula #175

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

TyHil
Copy link
Member

@TyHil TyHil commented Nov 5, 2023

I was updating the Trends icons and decided to standardize the favicons and open graph data on all the Nebula sites. This PR updates the favicons to the new Nebula logo and adds/standardizes the Open Graph metadata.

Every site should now follow the same template for the head tags in _app.tsx and _document.tsx which all link to the same corresponding icons. I also stored this icons in this drive link.

Other sites PRs:
UTDNebula/utd-trends#123
UTDNebula/website-v2#19
#175
UTDNebula/planner#731

Copy link

vercel bot commented Nov 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jupiter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2023 0:55am

@TyHil TyHil changed the title Add favicon and open graph data Standardize favicon and open graph data Nov 5, 2023
@TyHil TyHil changed the title Standardize favicon and open graph data Standardize favicon and open graph data across Nebula Nov 5, 2023
@TyHil TyHil marked this pull request as ready for review November 5, 2023 02:27
Copy link
Contributor

@RubenOlano RubenOlano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@RubenOlano RubenOlano requested a review from beamandala November 6, 2023 21:59
@RubenOlano RubenOlano merged commit a92dd0e into develop Nov 7, 2023
1 check passed
@RubenOlano RubenOlano deleted the standardize-favicon branch November 7, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants