Standardize favicon and open graph data across Nebula #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TyHil
changed the title
|
Thanks for making this change @TyHil 🎉 |
|
Vercel Preview URL 🚀 : https://planner-oeb6w6ort-utdnebula.vercel.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was updating the Trends icons and decided to standardize the favicons and open graph data on all the Nebula sites. This PR updates the favicons to the new Nebula logo and adds/standardizes the Open Graph metadata.
Every site should now follow the same template for the head tags in
_app.tsxand_document.tsxwhich all link to the same corresponding icons. I also stored this icons in this drive link.Other sites PRs:
UTDNebula/utd-trends#123
UTDNebula/website-v2#19
UTDNebula/jupiter#175
#731
Planner specific note:
I could use some help as to why this isn't passing checks. I tried to branch off of a commit that was passing deployment as it seems a lot of recent commits on dev for dependency bumps weren't passing but it seems
npm ciis failing in the tests.